osmandapp / OsmAnd

OsmAnd
https://osmand.net
Other
4.59k stars 1.01k forks source link

Enable "Dirt Bike" routes settings based on `dirtbike:scale` #18756

Open cmoffroad opened 9 months ago

cmoffroad commented 9 months ago

Describe the idea (required)

Activate the "Dirt Bike" option in the Route Options menu using a toggle switch for On/Off functionality.

Tell us about the expected behaviour (required)

Upon activation, display a colored route overlay for all paths marked with the dirtbike:scale tag, similar to the approach used for mtb:scale (Mountain bike).

Tell us about alternatives you've considered (required)

Currently, the only option available is to create a custom renderer. With the increasing popularity of dirt bike communities worldwide, particularly in developing countries, I believe it's crucial to enhance data accessibility for them.

Context (optional)

Optionally, consider renaming the menu item to "Dirt Bike Routes." Alternatively, transform it into a "Motorcycle Routes" menu featuring a sub-menu dropdown:

COLOR ROUTES BY...

This could serve as encouragement for other mappers to introduce a separate scale for on-road motorcycles.

vshcherb commented 5 months ago

There is about https://taginfo.openstreetmap.org/keys/dirtbike%3Ascale#overview 8000 segments

cmoffroad commented 4 months ago

@vshcherb I have upgraded the existing wiki page and included references to OsmAnd rendering support, to give both tag and project more visibility: https://wiki.openstreetmap.org/wiki/Key:dirtbike:scale

Since dirtbike:scale is already supported in OBF process (see https://github.com/osmandapp/OsmAnd-resources/pull/829 ), and values match those of mtb:scale, I am hoping the implementation could be straightforward.

If you need any development support, I am happy to submit a partial/full PR if you provide me hints on what files need to be updated.

cricri-du-lauragais commented 4 months ago

hello, I've added these tags to the “enduro” rendering that you can find here : https://github.com/OsmAnd-Rendering/Motorcycle/blob/main/README.md dirtbike:scale=0 green dots on the track dirtbike:scale=1 orange dots on the track dirtbike:scale=2 orange dots on the track dirtbike:scale=3 red dots on the track dirtbike:scale=4 red dots on track dirtbike:scale=5 and 6 black dots on the track

cmoffroad commented 4 months ago

hello, I've added these tags to the “enduro” rendering that you can find here :

Thanks a lot, Christoph! Really appreciate what you're doing. Still it'd be great to make those dirtbike:scale routes visible to all OsmAnd users, no matter which renderer they're using.

By the way, I’d love to see your amazing routing work for enduro get added into OsmAnd :)

cricri-du-lauragais commented 4 months ago

thanks :) I've added these dirtbike:scale tags to the 3 routings, now it's time to test them.

vshcherb commented 4 months ago

To design: Dirt bike classification is similar to Difficulty classification / Difficulty of Hourse Trails. Could overlap with Smoothness / Surface / Access. Possible section name Road details

Introduce new menu in Configure Map, with list of all road classifications

vshcherb commented 2 weeks ago

The option will be called "Dirt bike roads".

Related section Roads / Trails:

cmoffroad commented 2 weeks ago

The option will be called "Dirt bike roads".

Great. Can we rename 'roads' to 'trails' instead? Like in MTB, most dirtbike routes are single trails or old double tracks, while unpaved roads are more commonly used by light off-road adventure motorcycles.

xmd5a2 commented 1 week ago

I've added "Show dirt bike trails" option. Name was chosen according to existing options. Styling and colors according to @cricri-du-lauragais's enduro style изображение

изображение

Maps needs to be regenerated to use it but enduro style should work without changes.

cmoffroad commented 1 week ago

I've added "Show dirt bike trails" option. Name was chosen according to existing options. Styling and colors according to @cricri-du-lauragais's enduro style

@xmd5a2 Great!

Could you please also add the green dots for dirtbike:scale=0 ?

I believe this is also how @cricri-du-lauragais designed it: https://github.com/osmandapp/OsmAnd/issues/18756#issuecomment-2082651475

xmd5a2 commented 5 days ago

Done изображение

How to test: update Thailand map (will be available today), enable "Show dirt bike trails" rendering style option and go to https://www.openstreetmap.org/way/151464598

cmoffroad commented 2 days ago

Done изображение

Thanks, it looks awesome!

Quick thought—do you think it would make sense to use different shapes for levels that are grouped (1/2, 3/4, and 5/6)? Or maybe, since most tags will likely be at the lower end (0, 1, 2), it might be helpful to highlight number 1 with a different color, like yellow. What do you think?