search

osmandapp / OsmAnd

OsmAnd
https://osmand.net
Other
4.63k stars 1.01k forks source link

Downloading maps of all regions of Norway doesn't download Oslo #20127

Closed dafadllyn closed 3 weeks ago

dafadllyn commented 3 months ago

Description

Downloading the maps of all regions of Norway doesn't download the map of Oslo.

Steps to reproduce

  1. Touch on "Maps & Resources" in the hamburger menu.
  2. Under "Regions" select "Europe" and then "Norway".
  3. Under "Regionwide maps" touch on the download button to the right of "Standard map".
  4. Make sure that all regions are selected. (Note that OsmAnd only lists 12 regions although one screen back under "Regions" it lists 13.)
  5. Touch on "Download".

Actual result

The maps of all regions except of Oslo is downloaded.

Expected result

The map of Oslo should also have been downloaded.

Your Environment (required)

WARNING Crash-Logs MAY contain information you deem sensitive. Review this CAREFULLY before posting your issue!

OsmAnd Version: 4.7.17
Android/iOS version: Android 14
Device model: Google Pixel 6a
Crash-Logs: ?
scaidermern commented 3 months ago

Expected result

The map of Oslo should also have been downloaded.

Why?

The map for region Viken already contains Oslo. If you download the map for Oslo while having the map for Viken downloaded you will have duplicated data, leading to various problems (#15039).

yuriiurshuliak commented 3 months ago

The bug has been reproduced. To reproduce it, attempt to download all regions of Norway simultaneously. Once the download completes, you should observe that the Oslo map is missing.

OsmAnd~ 4.8.0#2533m, released: 2024-06-19

scaidermern commented 3 months ago

Then I'm mistaken and Viken doesn't contain Oslo. This isn't obvious since when tapping on the Viken region on the map, OsmAnd displays it in such a way that Oslo is covered.

vshcherb commented 2 months ago

Probably bug is in Android, though if it's hard to fix we could extend map to contain Oslo similar to Brandenburg @Chumva @xmd5a2

Chumva commented 2 months ago

We filter some regions here by excluding nested subregions, avoiding duplication of what's already included in the top-level region

xmd5a2 commented 2 months ago

If we actualize Norway subdivisions then issue will be fixed automatically. Oslo was inside Viken region which was short-lived: https://en.wikipedia.org/wiki/Viken_(county) Now there are 3 regions at Viken territory and Oslo. None of them contains Oslo inside it.

vshcherb commented 1 month ago

Yes we should follow new structure - 1 Viken

xmd5a2 commented 1 month ago

New Norway regions was added: Akershus, Buskerud, Finnmark, Østfold, Troms, Vestfold, Telemark Tifheightmap and SRTM were generated and uploaded. Regular maps will be generated at the beginning of September. Old regions to remove: troms-og-finnmark, viken.

DmitryAlexei commented 5 days ago

Oslo now can be found as a separate map. Oslo and new regions Akershus, Buskerud, Finnmark, Østfold, Troms, Vestfold, Telemark, as well as the Norway contour lines and hillshades maps can be downloaded and work properly.