osmandapp / OsmAnd

OsmAnd
https://osmand.net
Other
4.37k stars 987 forks source link

Search does not find Scottish parliament despite me hovering over it #20185

Open mlell opened 1 week ago

mlell commented 1 week ago

Description

it doesnt find it, maybe because its a relation?

Steps to reproduce

Actual result

the top hit is "Parliament Square" (55.94885 -3.19073), which is not near the Parliament in Edinburgh

Expected result

Expected: It shows me The Schottish Parliament, Relation 4599

Your Environment (required)

OsmAnd Version: 4.7.10
yuriiurshuliak commented 1 week ago

The bug was not reproduced. To reproduce this bug, I downloaded the relevant map and navigated to coordinates 55.95200, -3.17509. When searching for "Parliament," I successfully found "Parliament building" and "Parliament house." However, "Parliament building" appeared 11th in the search results, and "Parliament house" was 18th.

OsmAnd~ 4.8.0#2591m, released: 2024-06-26

mlell commented 1 week ago

Thanks for taking a look into this. "Parliament building" is indeed the name of one of the buildings that make up the mentioned relation. However, this is a mere coincidence. The tags for Tourist Attraction and Government building are not on this building but on the relation. Conversely, for example the debating chamber, clearly part of thw parliament, is not part of the "Parliament building" object. Therefore, I have the impression thad you did in fact reproduce the buggy behaviour by not recovering the mentioned relation.

"Parliament House" is unrelated to the Scottish Parliament" (https://en.m.wikipedia.org/wiki/Parliament_House,_Edinburgh)

26.06.2024 16:29:10 yuriiurshuliak @.***>:

The bug was not reproduced. To reproduce this bug, I downloaded the relevant map and navigated to coordinates 55.95200, -3.17509. When searching for "Parliament," I successfully found "Parliament building" and "Parliament house." However, "Parliament building" appeared 11th in the search results, and "Parliament house" was 18th.

OsmAnd~ 4.8.0#2591m, released: 2024-06-26

photo_2024-06-26_18-23-21.jpg (view on web)[https://github.com/osmandapp/OsmAnd/assets/127092082/91142ee4-fc62-49b7-afda-10fcd49ef0a4]

— Reply to this email directly, view it on GitHub[https://github.com/osmandapp/OsmAnd/issues/20185#issuecomment-2191998268], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AD3VVISPYSURNMS4D44QDNDZJLM4NAVCNFSM6AAAAABJ5URNT6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJRHE4TQMRWHA]. You are receiving this because you authored the thread. [Verfolgungsbild][https://github.com/notifications/beacon/AD3VVIRQJ6456LLPRCAJWG3ZJLM4NA5CNFSM6AAAAABJ5URNT6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUCU46TY.gif]

mlell commented 1 week ago

I just noted that I was not entirely correct. The found "Parliament building" is Relation 12659152, which includes the debating chamber building but not the tourism=attraction and office=government tag. It has building=government though. The aforementioned relation 4599 has the first two tags and contains most objects of relation 12659192, but in addition e.g. the MSP House at the west side of the parliament building. But neither of the two relations is contained within the other. So one could debate whether it could be mapped in a better way but the core problem stays that there is a government office/tourist attraction object which does not get picked up by the search