search

osmandapp / OsmAnd

OsmAnd
https://osmand.net
Other
4.59k stars 1.01k forks source link

Shops are not recognized as POI #20506

Open tommycrock opened 1 month ago

tommycrock commented 1 month ago

Description

Shops with a tag that osmand doesn't recognise don't display the opening hours on the POI popup card. e.g. https://www.openstreetmap.org/way/1294840099 has shop=catalogue, which is shown as a shop but the opening hours are missing.

Steps to reproduce

Navigate to https://www.openstreetmap.org/way/1294840099 (Yorkshire, England) and click it.

Actual result

The card is shown but there's no opening hours displayed.

Expected result

Opening hours displayed

Your Environment (required)

WARNING Crash-Logs MAY contain information you deem sensitive. Review this CAREFULLY before posting your issue!


OsmAnd Version: 4.8.4
scaidermern commented 1 month ago

Same bug for this shop: https://www.openstreetmap.org/node/6812096181 (shop=costumes)

vshcherb commented 1 month ago

Reproduced, if you click edit POI - information is parsed correctly however it's not displayed whether POI open or not

scaidermern commented 1 month ago

In my case no information is displayed at all (no name, no website, no opening hours). Except for the URL to the OSM node.

tommycrock commented 1 month ago

Yes, I also see no name (just location). My example doesn't have other tags but presumably also missing

vshcherb commented 1 month ago

We need to index all shops as POI may be make a generic-catch category somehow and encode specific type as text

vshcherb commented 6 days ago

To do: on generation site we need to add "catch-up" tag in poi_types.xml, so if shop is not one of listed, it converts to shop=general + shop:type=catalogue