zoom by volume button: one press of vol+ results in 2 zoom+ events, while vol- works as expected

osmandapp / OsmAnd

OsmAnd

https://osmand.net

Other

4.59k stars 1.01k forks source link

zoom by volume button: one press of vol+ results in 2 zoom+ events, while vol- works as expected #20615

Open spongebyte opened 1 month ago

spongebyte commented 1 month ago

Description

Hi, I use the vol+/vol- buttons in OsmAnd to control zoom. I've noticed that vol+ results in 2 zoom in, while vol- works as expected.

In other words, if I press vol+ once, I'll need to press vol- twice in order to get back to the previous zoom level.

Steps to reproduce

Enable volume buttons as zoom: hamburger menu > Configure profile > General settings > Volume buttons as zoom. Zoom in and zoom out.

Actual result

One vol+ press results in 2 zoom-ins. One vol- press results in 1 zoom-out.

Expected result

One vol+ press should result in 1 zoom-in. One vol- press should result in 1 zoom-out (already working as intended).

Your Environment (required)

Pixel 6a. LOS 21 / Android 14. OsmAnd~ 4.8.5.

mikehgentry commented 1 month ago

On an XCover 4s I'm seeing two zoom events for both in and out.

I think it used to work fine pre 4.8, but I don't use it that often so might be wrong.

XCover 4s, Android 11, +4.8.6

DmitryAlexei commented 1 month ago

OsmAnd~ 4.9.0#2994m, released: 2024-08-15

Steps to reproduce

enable zoom level widget
enable Volume buttons as zoom option
zoom in and out using +- volume buttons

Actual result

volume buttons change zoom level in an unexpected way: sometimes +-2 steps, sometimes +-1 step

https://github.com/user-attachments/assets/798d5596-4a36-4b77-9014-cb7cdbc0b930

vshcherb commented 3 hours ago

Didn't reproduce. Fast click always changes with 1 increment, however it's not easy to do 1 click as button tends to cause 2-3 clicks which is normal for volume control but unwanted behavior for zoom-in-out. You can disable animations to get better effects

spongebyte commented 2 hours ago

Hey. Thanks for your response. If the 2-click issue was a result of vol-up acting as 2 clicks instead of 1, shouldn't I expect the vol-down to have the very same problem? I have the problem only on vol-up. My vol-up and vol-down work properly in other apps (well, for volume control that is).