Opening_hours for a public holiday weekday does not work

[Rpnpif]

Description

OsmAnd shows a false opening_hours when a weekday is selected on public holidays.

Steps to reproduce

Attribute : opening_hours=07:00-14:00,15:30-19:00; PH Su closed As on https://www.openstreetmap.org/way/154728267

Actual result

OsmAnd shows Mo-Su 07:00-14:00, 15:30-19:00 24/7 closed and says that the shop is always closed.

Expected result

The shop should be shown opened from 07:00 to 14:00 and from 15:30-19:00 but Sunday only when Sunday is on a public holidays. Example : The 14 July 2024 in France is a public holiday. This shop is closed because it is a Sunday. All other days, this shop is opened on the mentioned hours. Confirmed with https://openingh.openstreetmap.de/evaluation_tool/ with latitude=47 and longitude=0.

Your Environment (required)

OsmAnd Version: 4.8.4 Android/iOS version: 8.0.0 Device model: Huawei

[yuriiurshuliak]

It's likely that we do not support the opening_hours:PH tag, which would explain the behavior you're observing. More information: Taginfo - opening_hours.

[Rpnpif]

@yuriiurshuliak I understand but I think that when PH is present, OsmAnd should not show 24/7 closed all the times. It should ignore the PH sequence after the last ; sign.

[yuriiurshuliak]

The bug has been reproduced. To reproduce it, navigate to coordinates 47.675280, -0.883823, download the relevant map, and enable live map updates.

When clicking on this POI, it incorrectly displays "24/7 closed," despite the tag indicating opening hours as 07:00-14:00, 15:30-19:00, with Sundays and public holidays closed.

You can view the object in OSM here: https://www.openstreetmap.org/way/154728267

OsmAnd~ 4.9.0#3030m, released: 2024-08-20

[vshcherb]

Syntax Mo-Fr 10:00-20:00; PH Su off is likely not correct, the standard way of defining is Mo-Fr 10:00-20:00; PH, Su off. I know evaluation tool support but that doesn't mean it's correct.

[Rpnpif]

@vshcherb : My report is about Mo-Su 10:00-20:00 , not Mo-Fr 10:00-20:00. PH, Su off means that it is closed during public holidays AND during all Sundays. But I want closed during Sunday if it is during public holidays. When Sunday is not when public holidays, it is opened. Example: 14 July 2024 is the national holiday in France AND it is a Sunday, so it is closed. Other Sunday, it is opened.

PH Su off without comma do the job but not in OsmAnd

[vshcherb]

My bad, didn't know about that use case