osmandapp / OsmAnd

OsmAnd
https://osmand.net
Other
4.64k stars 1.01k forks source link

Incorrect turn directions (Turn left became Keep left) #20828

Closed Guylby closed 1 month ago

Guylby commented 1 month ago

Description

Hi,

Since 4.9.0 I've noticed during car navigation that turn directions that previously were "Turn left" or "Turn right" have become "Keep left" and "Keep right" but this is incorrect. The intersections need you to exit the main road or are 1 lane only, so there is no lane to follow.

Steps to reproduce

Standard car profile was used, the problem is seen both in Osmand+ and osmand web Start point: 43.252674,6.099703 End point: 43.242835,6.085042

Here is two examples: https://test.osmand.net/map/navigate/?start=43.252674,6.099703&end=43.242835,6.085042&profile=car#16/43.2477/6.0873

Actual result

Instructions are Keep left and Keep right

Expected result

Instructions should be Turn left and Turn right (as they were before)

Your Environment (required)

WARNING Crash-Logs MAY contain information you deem sensitive. Review this CAREFULLY before posting your issue!

OsmAnd Version: 4.9.0
Android/iOS version: 13
Device model: Sony Xperia 10 III
Crash-Logs: ?
Guylby commented 1 month ago

Another example: A highway exit that should be "Turn right" is "Keep right": https://osmand.net/map/navigate/?start=43.251853,6.101178&end=43.249677,6.093786&profile=car#17/43.25089/6.09650

yuriiurshuliak commented 1 month ago

The bug has been reproduced. During navigation, the turning directions are incorrectly indicated as "Keep left" and "Keep right" when exiting the main road or when driving in a single lane.

The expected behavior is for the directions to be "Turn left" or "Turn right."

You can view the web versions here and here.

OsmAnd~ 4.9.0#3179m, released: 2024-09-12

vshcherb commented 1 month ago

To have Keep left keep right is a correct version for many motorway link, to have correct or better interpretation turn:lanes are needed, we constantly fixing bugs so this change might be a problem for other cases and in situations where we can't determine unique behavior across all types we recommend using turn:lanes mapping

Guylby commented 1 month ago

I'm not a fan of this change has it results in more misunderstandings than correct routing especially considering how Osmand behaved before this change. When I hear "keep right", my understanding is to stay on the main road but keep to the rightmost lane. However all the examples I've presented require to exit the main road (or highway) and therefore there should be a "turn left or right" prompt as you have to change directions. Here is an example with the topology of the first intesection presented on the first post: When you have to go to the yellow road Osmand says "keep right", which is incorrect as you have to exit the main road and take the other road: Screenshot 2024-09-13 at 15-31-43 Google Maps

Before you heard turn right and you'd know that you should take the first exit that appeared. Now with this behaviour you have to check on the gps to know if it's a "keep right" to stay on the main road or a "keep right" to exit the same road, which is really confusing. Just yesterday on a short 1h trip without going on highways I had five times the "Keep right" instead of "Turn right" instructions, when in reality it was all the same scenarios as presented above, a single lane with an exit going another direction. I've tested OSRM and other route navigation software and all used a "Turn" instruction and not a "Keep".

With this change you'd have to manually edit an enormous number of intersections with single lanes with the turn:lanes key to correct them just for Osmand which seems an absurd amount of work.

It's also not consistent on highways, some exit are "turn slighty right", other "keep right" when they are mapped the same and are identical in reality: an exit where you have to exit the rightmost lane:

Screenshot 2024-09-13 at 15-49-53 Google Maps If I hear "Keep right" I'd stay on the rightmost lane which is the Red one and miss the exit

Guylby commented 1 month ago

Another example at this intersection: https://test.osmand.net/map/navigate/?start=43.220322,6.067811&end=43.220357,6.067656&profile=car#17/43.22267/6.06873

Here you have a keep left on a single lane road to take the left exit and go on the motorway with a sharp turn Screenshot 2024-09-13 at 16-38-52 OsmAnd Map