Do not delete placeholder item when deleting a downloaded plugin

Norbert80 commented 3 days ago

Description

Steps to reproduce

Go to the plugin list
Install "Map Legend" (or any other plugins that requires a download
Go back to the plugin list
Tap the ... button on the "Map Legend" item
Press Delete (in german screenshot: Löschen)

Actual result

The "Map Legend" item is completely removed from the plugin list
Leave and re-enter the plugin list

Now the "Map Legend" plugin is available again for download.

Expected result

"Delete" should not remove the placeholder item from the plugin list

Your Environment (required)

OsmAnd~ 4.8.5 from F-Droid

yuriiurshuliak commented 2 days ago

The bug could not be reproduced. To test this, install the Map Legend plugin, then go to the plugin list, click on the three dots next to the plugin, and select "Delete" After doing so, exit the plugins tab and log back in.

The plugin will still appear in the list, but it will no longer be downloaded.

OsmAnd~ 4.9.0#3314m, released: 2024-09-30

https://github.com/user-attachments/assets/ff3170b9-9f7b-4dc9-8738-4d2b634ac890

Norbert80 commented 2 days ago

The item should stay in list after tap on Delete. As you describe you have to leave and re-enter to have the item again in the list.

osmandapp / OsmAnd