"OSF" export changes default profile settings

Zirochkabila commented 6 days ago

Description

Related to 21474

Standard backup file changes the profile settings to custom ones, which leads to a failure in the selection of Units & Formats categories

Steps to reproduce

Delete all data - simulate the first startup with default profiles (restoring the default settings does not help)

Menu > Settings > Driving > Export to file > Continue > Export osf.
Select osf file > OsmAnd > Settings select > Continue > Replace all > do this steps 21474

Actual result

After export (importing) the osf file, the default settings are replaced with custom ones (although no replacement has been made)

What makes it impossible to change data in Units & Formats categories

Expected result

When exporting (importing) data, the data retains its standard form and cannot be changed

Your Environment (required)

WARNING Crash-Logs MAY contain information you deem sensitive. Review this CAREFULLY before posting your issue!

OsmAnd Version: OsmAnd~ 5.0.0#3834m, Released: 2024-11-28
Android/iOS version: Android 14
Device model:
Crash-Logs: ?

yuriiurshuliak commented 2 days ago

After testing, I was unable to reproduce the described bug. Here are the steps I followed:

Performed a Clean Installation of OsmAnd.
Checked the Units & Formats categories for the driving profile and confirmed that after a clean installation, everything worked correctly. The Units of speed and Units of volume changed as expected when modifying the Driving Region.
Exported the default settings to an OSF file.
Re-imported the same OSF file using the Replace all option.

After re-importing, I repeated the steps from #21474:

Changed the Driving Region from Automatic to Europe, then from Europe to USA.

Results:

The Units of speed and Units of volume categories in the profile settings remained unchanged, still reflecting European units (km/h and liters) instead of switching to USA units (mph and gallons).
However, after exporting and importing the OSF file, the default settings were not replaced with custom ones. The data remained in its standard form, and there was no failure to change the Units & Formats categories.

This suggests the issue is specifically linked to modifying Driving Region behavior rather than the OSF import/export process. Please let me know if there are additional details or steps I might have missed that could help reproduce the issue more accurately.

vshcherb commented 2 days ago

We need to test that settings that are not changed by user are not export to the settings. It's important that import won't overwrite default settings (which might be different) or settings set by the user on another device

DmitryAlexei commented 5 hours ago

Probably related with auto-backup option https://osmand.net/docs/user/personal/global-settings#auto-backup

osmandapp / OsmAnd