osmandapp / OsmAnd

OsmAnd
https://osmand.net
Other
4.65k stars 1.02k forks source link

OsmAnd+ 2.4: Sometimes changed marker position cannot be confirmed #2929

Closed Norbert80 closed 8 years ago

Norbert80 commented 8 years ago

There is a new feature introduced with OsmAnd 2.4 that shall allow to change the position of markers. Sometimes (sporadically) AFTER PRESSING OK, the windows does not close. A windows with only CANCEL option stays open. After pressing CANCEL the marker jumps back to the old position.

Found with OsmAnd+ 2.4.2. screenshot_2016-08-09-21-47-53 screenshot_2016-08-09-21-47-58

Norbert80 commented 8 years ago

@vshcherb Are there any related patches integrated in OsmAnd+ 2.4.3? I can't reproduce this bug anymore.

vshcherb commented 8 years ago

It was fixed in 2.4.3

Norbert80 commented 8 years ago

@vshcherb Now I see this bug again with OsmAnd+ 2.4.3. Please re-open.

vshcherb commented 8 years ago

I can not reproduce it any more, though by the time it was opened I was able to see it. I think it is my mistake and it didn't make to 2.4.3, so I expect it will be 2.4.4. Please test nightly build.

Norbert80 commented 8 years ago

I can confirm that this one is fixed since build 2.4.4.

Norbert80 commented 7 years ago

@vshcherb This issue is back in OsmAnd + 2.5. Please re-open it.

Norbert80 commented 7 years ago

At least the big orange marker is affected.

vshcherb commented 7 years ago

Can't reproduce please share screenshots

Norbert80 commented 7 years ago

Hi Victor,

attached you find the requested screenshots. (I cannot log in to GitHub during my holidays, sorry.)

Regards Norbert

Am 30. Oktober 2016 15:21:20 GMT+00:00, schrieb vshcherb notifications@github.com:

Can't reproduce please share screenshots

You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/osmandapp/Osmand/issues/2929#issuecomment-257157372

Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

sonora commented 7 years ago

I have tried hard, but cannot reproduce either. Must depend on some rather special circumstances or configuration.

Norbert80 commented 7 years ago

@vshcherb attached you find the requested screenshots that I already have sent you by mail. Sorry for the late response. I have been on vacation. screenshot_2016-10-28-15-56-22 screenshot_2016-10-30-17-12-36 screenshot_2016-10-30-17-12-52

sonora commented 7 years ago

So your are saying the "Apply" button is missing. I assume this is exactly in cases where the Lat + Lon display above it is stretched out over 2 lines?

Norbert80 commented 7 years ago

@sonora not really. But thanks for

But I found another related problem that may trigger that faulty behavior. On the canary islands I see this problem regularly.

If I click for example the "Holiday World" in the search results (or if I click the icon of the "Holiday World" which is a new feature of OsmAnd 2.5) to set the marker I found that the marker is miss-positioned (not on the icon).

This happens with many POI icons on the canary islands but the "Holiday World" is an extreme example.

From now on during the same OsmAnd session (no app re-start) if I set the marker to any ('non-snapped') position I experience the bug with the missing "Apply" button on the canary islands. screenshot_2016-11-07-20-57-49

sonora commented 7 years ago

Norbert, I think the marker when tapping a feature associated with an area is placed in the center of the enclosing area (this is a theme park), which is not necessarily where the icon of related points is shown.

I have just tried to reproduce with my September 1 Spain map, but still cannot ...

Norbert80 commented 7 years ago

@sonora I use the canary islands map. Did you also try with that

sonora commented 7 years ago

Yes. It's not a map issue, I think. Could be specific to certain hardwares' screen resolution, not sure.

sonora commented 7 years ago

PS: Is it the same in landscape mode?

Norbert80 commented 7 years ago

@sonora I see experience this bug also in landscape mode.

Norbert80 commented 7 years ago

It seem to be really related with the new feature to select POI icons. I experienced that the screen orientation change back to portrait mode has reset (removed) the bug.

The bug occurred again after selection such a POI with a difference in marker position. POIs with correct marker positions seem not to trigger the bug.

Norbert80 commented 7 years ago

@sonora please note that the Apply button vanishes after clicking on it. Could tis be the reason why you cannot reproduce it?

Norbert80 commented 7 years ago

@crimean thanks for working on these problems. Does your fix cover the vanishing Apply button or does it only cover the line break?

crimean commented 7 years ago

@Norbert80 Sorry, it was not complete fix. The Apply button should work ok now.

Norbert80 commented 7 years ago

@crimean thanks!

Norbert80 commented 7 years ago

@sonora I think found out why you couldn't reproduce the bug.

I had spain map and canary islands map installed at the same time when I experienced this bug on the canary islands. So this are was covered with two maps.

Since I have deleted the canary islands map I don't experience this bug on the canary islands anymore.

So it looks like this bug happens on areas with overlapping maps.

Could you please check and reopen this bug if you now can reproduce it?

Norbert80 commented 7 years ago

@vshcherb @sonora Now you should have alle information to reproduce the bug and re-open it. Please let me know if you can reproduce it now or if you need a step-by-step instructions.

sonora commented 7 years ago

@Norbert80 I have just tried with both Spain and Canary Island maps active, and find no problem ...

Are you sure you can still reproduce it?

Norbert80 commented 7 years ago

@sonora I installed Canary Islands map again in addition to the Spain on OsmAnd+ 2.5.4. I haven't been able to reproduce the bug anymore. So we can keep this issue closed.

I will update this issue if I experience the bug again in future. Thanks!

sonora commented 7 years ago

Ok, thanks! Best, Hardy