search

osmandapp / OsmAnd

OsmAnd
https://osmand.net
Other
4.69k stars 1.02k forks source link

show city next to search result #2993

Closed schiessle closed 3 weeks ago

schiessle commented 8 years ago

If you search for something which exists multiple times in your region, e.g. a shopping center like Ikea, you get multiple results and it is hard to judge which one ist he right one. On the search result, the only additional information you have is the distance to your current location. But that's not always enough, especially if you are in a foreign location. Therefore it would be really helpful to add some additional information to the search result, like for example the city.

vshcherb commented 8 years ago

It's kind of duplicate nice to have. Though it doesn't require full results geocoding and could be implemented just for city name.

sonora commented 6 years ago

This is requested very frequently, guess it should be in our 3.0 milestone. See e.g.

vshcherb commented 6 years ago

@sonora Very unlikely it will happen soon. The frequency of requests shows popularity but doesn't show the complexity. Ideally all POIs should have Street, City. City is not enough but in order to achieve it addresses should be prepared in the data which makes that story difficult to implement

schiessle commented 6 years ago

@vshcherb why not doing it step-by-step if showing only the city would be easier? Sure, showing the complete address would be the perfect solution but having just the city would make search in many cases already much easier.

vshcherb commented 6 years ago

If we are talking about popular POI in large cities than their name is mostly irrelevant. If we are talking about correct information it requires address lookup for each poi.

jfburke3 commented 2 years ago

Would displaying the value for the "branch" tag be easy, if the value is not null? E.g., a displayed result might appear as "Wells Fargo (Wildwood)" for a Wells Fargo bank location with branch=Wildwood set in OSM.

I don't know about the rest of the world, but in the US and Canada, it is fairly common for some types of businesses to identify various locations by branch.

EvanCarroll commented 2 years ago

@jfburke3 that be preferable imho and no more difficult. We track that here https://github.com/osmandapp/OsmAnd/issues/6947 For reference the OP is from Stuttgart, Germany. In Stuttgart there are five Starbucks. Knowing that they're all in Stuttgart is not very useful, however the branch names seem much more valuable (from Starbucks.com):

What would you rather have @schiessle those names above or just "Stuttgart". If you want the branch names, would it be cool to close this as a duplicate of this https://github.com/osmandapp/OsmAnd/issues/6947 ?

schiessle commented 2 years ago

I agree, with your example the branch name makes totally sense. I just wonder if this always works? For example, assume that I'm in a place with three IKEA around. All with more or less the same distance, will in this case the branch name also tell me which one is the right one? Or will in this case the address/city be the better differentiator?

EvanCarroll commented 2 years ago

Branch is left for the operator to assign. The idea being if the operator disambiguates their stores we do not have to. In the case of multiple stores in the same city, you'll typically find the name of the commercial center they're located in but not always. Sometimes, like with Dominos, you see the street name. I don't think there are ever two IKEA's in the same city. At least in the USA. Looking it up the tag:branch for the IKEA, is always city. You can see it with their store locator,

IKEA Houston
7810 Katy Freeway
Houston, TX 77024

Houston is the branch.

mmacura311 commented 1 year ago

This is also a problem when using osmand with android auto. I search for "decathlon" or "ikea" and I have no clue which one to select, as there are multiple in roughly the same air distance. It would be great to see a city and maybe even full address of the poi.

scaidermern commented 1 year ago

I guess it is an expensive operation to perform reverse geocoding for each search result. Maybe this step can already be performed during map generation?

sonora commented 1 year ago

Organic maps seems to have this pretty instantaneous, we could research how.

Also, not sure if this is a notable relief, but I think you need the street address on the search result screen only for vicinity hits, maybe closer than 10 km or within the same town, while for farther hits the town or village should suffice?

So I guess either our search index could tag all hits with a municipality denoting town/village, or we create such a municipality raster and an associated lookup method which would use any arbitrary coordinates input to output the municipality.

canoine commented 1 year ago

I met an annoying case today : a hamlet with a common name :

Screenshot-20230714-165047-Osm-And.jpg

Here, I need to know how far is my destination. But that's precisely what I don't know, as I need a navigating app to go there. After half an hour of "die-and-retry" tests to find the right hamlet, I asked my wife to run Waze on her phone.

Is it possible to add, say... the postal code of the results ?

lcosmin commented 1 year ago

I met an annoying case today : a hamlet with a common name : [...]

Annoyances like this make the search sometimes impossible to use.

Not sure if this approach is possible to implement, but when the exact address is missing for a search result, the closest (important) street could be located (like with a 100 m radius), then the "next big feature" that contains the street (e.g. city), then the next big feature that contains the city (like the local region name or whatever administrative division there is in that country) and then the country itself.

So, I have 3 Hornbach stores near me, for all of them, when I search, I get "HORNBACH - home improvement store ~12km". Needless to say the results are pretty useless. But with the above mentioned heuristic, I could get:

I realize this is probably easier said than done, but maybe it's something that could be taken into consideration.

blackboxlogic commented 11 months ago

A similar issue but at higher scale, that may be easy to fix simultaneously.

When I search for a town by name (for example "Concord"), OsmAnd shows a list of results including: Name, Type, Distance. But there are two Concords, at 67 miles and 91 miles away, I don't know which one I want. I'm trying to go to Concord, Massachusetts, but I must use guess-and-check to find it.

The search result would be much more helpful if (when searching for municipalities) it named the next one or two higher municipal boundaries. Example:

Or maybe, small text at the bottom of the result, the full chain of higher boundaries:

vshcherb commented 10 months ago

Technical plan:

vshcherb commented 3 months ago

Technical note:

vshcherb commented 1 month ago
ivanPyrohivskyi commented 1 month ago

Need new maps (October 2024) for test

dmpr0 commented 1 month ago

Review

Screenshot
"silpo" Selected brand
MarioSwitch commented 1 month ago

@dmpr0 Build 4.9.0#3416m Not reproduced with Hauts-de-France map (october 2024, with Live Updates)

City shoud be shown for every search result (excluding cities themselves), not only by searching a specific brand...

Classic search Brand search
sonora commented 1 month ago

I have tried with latest maps and latest nightly - I never see a city or location under any search result...

vshcherb commented 1 month ago

To fix:

vshcherb commented 1 month ago

@sonora tested again in Netherlands - sometimes it shows. Germany maps need to be regenerated, today will be scheduled tomorrow should be available to redownload - @ivanPyrohivskyi will let know

Fixed - https://github.com/osmandapp/OsmAnd-tools/pull/928

vshcherb commented 1 month ago
vshcherb commented 1 month ago

Maps with Germany France updated and cities are present

MarioSwitch commented 1 month ago

@vshcherb No updates available, search results doesn't show cities with latest Live Updates (3:00 PM GMT+2)

pebogufi commented 1 month ago

@vshcherb No updates available, search results doesn't show cities with latest Live Updates (3:00 PM GMT+2)

Confirm that. No cities... Maps downloaded 2024-10-15 15:03 France_great-east_europe_2.obf.zip Germany_baden-wuerttemberg_europe_2.obf.zip Edit: Searched for Edeka (Germany) Super U (France)

MarioSwitch commented 1 month ago

@pebogufi I don't know if "updates" are Live or not?

Because app still says latest (non-Live) update for France and Germany are Oct 1, 2024... Edit: Searched for Intermarché (France) and MPREIS (Germany)

pebogufi commented 1 month ago

I removed last obf, downloaded the available from https://download.osmand.net/list.php and installed them. Same result with Live on/off (for test "off" i renamed dir)

MarioSwitch commented 1 month ago

@sonora tested again in Netherlands - sometimes it shows. Germany maps need to be regenerated, today will be scheduled tomorrow should be available to redownload - @ivanPyrohivskyi will let know

Fixed - https://github.com/osmandapp/OsmAnd-tools/pull/928

You're right, it works in the Netherlands 😅 (Map is from Oct 1, without Live Updates)

vshcherb commented 1 month ago

Maps needs to be deleted and redownloaded. Please let us coordinates and poi category to test

MarioSwitch commented 1 month ago

It works after re-download maps!

MarioSwitch commented 1 month ago

Please let us coordinates and poi category to test

It's around Arras, Hauts-de-France, France

blackboxlogic commented 1 month ago

For contributors of OSM, can we get a brief description of how this is implemented? For example, does it show the name of the closest node with place=city? Will it consider towns and hamelts, municipal boundaries, etc?

sonora commented 1 month ago

No luck here, also with new map: Screenshot_20241016-182234_OsmAnd~

Map position somewhere near Stuttgart.

MarioSwitch commented 1 month ago

@sonora

Reproduced, Burger King near Stuttgart

vshcherb commented 3 weeks ago

Combined maps will be regenerated tomorrow and once tested, updated will be posted

vshcherb commented 3 weeks ago

Right now you can download individual maps of Stuttgart

ivanPyrohivskyi commented 3 weeks ago

Test on countries Germany_baden-wuerttemberg_europe_2.obf Germany_bayern_europe_2.obf Germany_hessen_europe_2.obf Germany_niedersachsen_europe_2.obf Germany_nordrhein-westfalen_europe_2.obf Ukraine_europe_2.obf