Replace prebuilt jar files with Maven dependencies

[yourealwaysbe]

I have been working on adding the new version of OsmAnd to the F-Droid repository. A problem here is that F-Droid does not accept prebuilt binaries. Our discussion can be followed here.

One hopefully easy to fix issue is the number of libraries distributed with OsmAnd that could be replaced by Maven dependencies. The purpose of this post is to ask:

• would OsmAnd be willing to accept a patch/pull request to replace these dependencies?
• are our chosen replacements for version mismatches benign?

We have been able to remove all jar files and still compile OsmAnd with the following replacements. Our simple testing seems to show no problems. I will list the replacements in full before discussing mismatches.

In OsmAnd/build.gradle, the fileTree dependencies can be replaced with

compile 'commons-logging:commons-logging-api:1.1'
compile 'it.unibo.alice.tuprolog:tuprolog:3.2.1'
compile 'org.beanshell:bsh-core:2.0b4'
compile 'com.ibm.icu:icu4j:50.1'
compile 'fr.univ-valenciennes:bzip2:1.0'
compile 'com.moparisthebest:junidecode:0.1.1'
compile 'net.sf.trove4j:trove4j:3.0.3'
compile 'org.immutables:gson:2.5.0'
compile 'com.vividsolutions:jts-core:1.14.0'

In OsmAnd-java/build.gradle, the dependencies can be replaced with

compile 'commons-logging:commons-logging:1.1.1'
compile 'net.sf.trove4j:trove4j:3.0.3'
compile 'org.json:json:20090211'
compile 'it.unibo.alice.tuprolog:tuprolog:3.2.1'
compile 'net.sf.kxml:kxml2:2.3.0'
compile 'org.beanshell:bsh-core:2.0b4'
compile 'com.ibm.icu:icu4j:50.1'
compile 'fr.univ-valenciennes:bzip2:1.0'
compile 'com.moparisthebest:junidecode:0.1.1'
compile 'com.vividsolutions:jts-core:1.14.0'

There are the following mismatches:

• gnu-trove-osmand.jar replaced with net.sf.trove4j:trove4j:3.0.3. What is gnu-trove-osmand? If it is a bespoke version of GNU Trove, where can the source be found?
• tuprolog.jar replaced with it.unibo.alice.tuprolog:tuprolog:3.2.1. Which version of tuprolog is used by OsmAnd?
• icu4j-49_1_patched.jar replaced with compile 'com.ibm.icu:icu4j:50.1' in the hope that whatever patch was applied appears also in 50.1. What patch has been applied (and is the source available)?
• bzip2-20090327.jar replaced with compile 'fr.univ-valenciennes:bzip2:1.0'. Here i took the latest version available on Maven: i did not see one close to a 2009 release date.
• junidecode-0.1.jar replaced with compile 'com.moparisthebest:junidecode:0.1.1'. There is a .1 version difference.
• simple-logging.jar not replaced in OsmAnd-java (it was not needed). It was replaced by commons-logging:commons-logging-api:1.1 in OsmAnd. I could not find any sources for simple-logging.jar, but its contents are similar to commons-logging-api. The main difference is that the provided Log class requires a few more abstract methods to be implemented. I added the following code to OsmandLogImplementation in PlatformUtil.java:

  public void trace(Object message) { }
  public void trace(Object message, Throwable t) { }
  public boolean isTraceEnabled() { return false; }

I have seen a similar issue raised before. However, hopefully this request is simpler, and i'm volunteering to make the patch.

[vshcherb]

It sounds good to me though it is required in depth testing. I would not volunteer myself of doing it but I would recommend it to do to double check sanity of libraries & also make it developer friendly. So it is definitely worth to create pull request & test if it works correctly. I would be happy to comment if there are any issues.

P.S. all the jars are explained correctly to my view.