osmandapp / OsmAnd

OsmAnd
https://osmand.net
Other
4.63k stars 1.01k forks source link

Offline search: allow POI fuzzy search #5409

Open bagage opened 6 years ago

bagage commented 6 years ago

The auto-complete list of POI searchbar is too much sensitive, specially with accented characters (é È ï î). For instance in French, if you type gite instead of gîte, the latest won't show up.

This is specially bad on mobile where you skip accented characters on purpose due to poor accessibility.

It would be great if either:

edit: maybe should use Collator class.

ryder-hook commented 2 years ago

II don't understand why #14198 was closed. In my opinion, these two problems have nothing to do with each other. By the way, Bolanzo is the official Italian spelling for this town. There are no special characters in it (like hotel above). The problem with #14198 is that Bolanzo is generally not found. No matter what street or place is searched for. And yes, my expectation is that the place will be found if I enter the official name of the town.

scaidermern commented 2 years ago

II don't understand why #14198 was closed. In my opinion, these two problems have nothing to do with each other. By the way, Bolanzo is the official Italian spelling for this town.

No, the official spelling is Bolzano, not Bolanzo :) And this is one the reasons why this issue is related to your other issue. Fuzzy searches allow for spelling mistakes.

ryder-hook commented 2 years ago

You are correct in that I gave the wrong spelling before. But that doesn't change my assessment, see the following screenshot. I searched by address and narrowed it down to cities. I am currently about 270 km away from Bolzano. In this overview, Bolzano should now appear between Bologna and Frauenkirchen in the search, but it does not.

scaidermern commented 2 years ago

Is this iOS? Looks a little bit strange to me.

For me on Android, searching for "Bol" (or Bolzano) correctly shows "Bolzano - Bozen" as a result.

ryder-hook commented 2 years ago

Yes it is iOS, newest version and newest iPhone.

barathrm commented 2 years ago

I'd be interested to know why this is considered "nice to have" only? In my experience everyone now expects fuzzy search from being trained by google to not having to remember names exactly. Or another example would be when I couldn't find an address in Osmand today because the website I'd gotten the address from had the address written in a slightly different way than the way it's published on Osmand. It couldn't find the address, even though only one letter was missing. With fuzzzy search, this would've worked. I must assume that a lot of people's search frustrations with Osmand could be solved with this.

antoine-gu commented 2 years ago

Absolutely necessary. I have searched for "greisslerei" and did not get the nearby location as it is written Stadtgreisslerei in osm. Well how could i know that someone named it that way. How could that be implemented. I think it would be great to have the possibility to choose between different searching algorithms or even add your own as you can add your own map sources.

Found this: https://pypi.org/project/fuzzywuzzy/