search

osmandapp / OsmAnd

OsmAnd
https://osmand.net
Other
4.72k stars 1.03k forks source link

Border Patrol announcement at crossing #5494

Open seahorse41 opened 6 years ago

seahorse41 commented 6 years ago

After adding the barrier "Border Control" tags, and getting the newest obf in time for another crossing this week, Yesterday after stopping at that location and turning off my vehicle to talk to the officer, OsmAnd choose a bad time to say "Attention Border Patrol" interrupting and covering the other person speaking.

I would think announcing it just as a rail road crossing is correct, when I am approaching it, but not after already doing so once, and NOT when I am already stopped.

After posting this issue at Google groups, I've determined this is a bug. Version net.osmand.plus_293.apk 2018-03-13 84853015 bytes Offline maps: Us_washington_northamerica_2..zip 2018-05-01 156815257 bytes Canada_british-columbia_northamerica_2.zip 2018-05-01 320105409 bytes

On the way northbound, I had Routing (Directions) active, Routing by car, it made the first announcement when approaching the border station at 48.999148 -118.504092 I forget if it announced a second time, but once I moved forward to speak with Canadian officers, it was silent.

On the way southbound, I did not have Routing active, so it was in World mode, just displaying so I could monitor my position and speed limits visually. I know GPS was locked on with good reception, because other apps in the background were recording data points again.

Playing back my dash cam, I can report the sequence of events. 16:41:54 49.000386 -118.503712 it made the first announcement "Attention Border Patrol" 16:42:05 49.000120 -118.503636 Stop. 16:42:17 Roll forward 16:42:27 49.000008 -118.503634 Stop. (coordinates according to Gmap4 satellite view) 16:42:34 Turned off engine, start conversation 16:42:45 "Attention Border Patrol" interruption. ( 48.99998;-118.50363 in the log, coordinates as recorded with only 5 digit precision = 1.27 meters accuracy, but it did not jump around or anything when stopped.)

sonora commented 6 years ago

Thanks for the feedback! Trying to analyze 1 by 1, as follows:

  1. I am not aware there is a voice prompt in the app announcing "border patrol", guess you misheard "border control"? Maybe a minor issue, but if you have a better wording suggestion, we can easily implement.

  2. The mechanism of when we announce what is a little different between the cases when you use a route/navigation and when you just ride along with the map view being active: This is necessarily so because when a navigation is active the app knows your likely path of travel, while in the absence of a route things are essentially based on mere proximity to a feature.

Side note: The voice module is only activated by a prior voice navigation, so if there was no routing since the app start there would always be silence.

  1. When a prompt is being prepared vs. played may be impacted by some other things going on in your device, so how reproducible your issue is would be interesting. While you maybe have a point that we may want to suppress or delay prompts at times when you are not moving, I am sure there are situations where this is not justified, so this would need further analysis.

From what I can tell your point is that for railroad crossings things work ok while for border stations they do not? Will have to look if the proximity of when we announce what differs between the 2 cases, that could certainly be aligned.

sonora commented 6 years ago

Looks like we are aiming to, subject to other priorities, announce border stations 7 seconds ahead or within 100 meters at the latest. For toll booths we have 30 sec/500m, maybe that would be more appropriate and better prevent prompts sound so late that you are already there ...?

seahorse41 commented 6 years ago

  1. I suppose it could be saying Control, but it sure sounds like Patrol. It's sad when I have 4 audio clips and I can't decide which it is.

  2. Yes the app was still running the same process since the routing navigation.

I used RR crossings as an example I heard last month, but I actually don't have any active railroads where I live. Perhaps it is not the best example. Also I don't sit at RR crossings for 1 or 2 minutes, unless I find an active train. Maybe stop light would be a better and more common example.

7 sec or 100 m seems consistent with my first crossing, while routing. It seemed adequate, although I can agree with your point it might be late enough to be somewhat Obvious at that point. Since I was certainly within the 100 m radius, I can't see the logic tree that triggered it to repeat the warning. Upon reviewing the full dashcam, I have to add it repeated again, or a third time at 16:43:35 just after starting the engine to leave. Is there a 50 second loop? I'll agree with the longer lead time for the first warning. I am still wondering about why it is repeating the warning. Thank you.

sonora commented 6 years ago

Ok, could you please check a few things for me:

seahorse41 commented 6 years ago
  1. Editing with iD In browser editor. Not Live, that would require an internet connection.
  2. There is one tag for each one-way road. Two total. Since I got a total of 3 voice warnings at the positions I mentioned. If each map carries a tag, that could be a cause. The recent fix, I look forward to.
  3. Navigation settings, Car, Repeat navigation instructions. Is set to Only manually.

Since I can say I did not tap the screen, this wasn't it.

sonora commented 6 years ago

Somehow it looks like this is a real time issue only, or can anyone rreproduce in a simulation?

seahorse41 commented 6 years ago

A comment was posted at groups.google.com/forum/osmand that sounds related, where a stop sign announcement kept repeating until navigation was finished. Also the bit about multiple crosswalks, tends to suggest increasing the distance from the control tag to make the announcement, would not be an improvement. Restricting the announcement to only play once seems more like the kind of logic that would help.