search

osmandapp / OsmAnd

OsmAnd
https://osmand.net
Other
4.67k stars 1.02k forks source link

Differentiate types of traffic calming in TTS #5605

Open StenSoft opened 6 years ago

StenSoft commented 6 years ago

There are different values for traffic calming in the map but TTS script only gets attention(TRAFFIC_CALMING). This makes it hard to provide meaningful TTS in Czech because each of the different values have special, commonly understood name but there is no commonly understood name for them all. It would be nice if the TTS script could differentiate between different traffic calming values (bump, hump, chicane, island, …).

sonora commented 6 years ago

This requires quite a sizeable change with little benefit to most other languages, and it could also lengthen the voice prompts, something per se rather to be avoided than desired. I am hoping you can find a viable way via wording.

Regarding your commit, I would certainly merge if you make it a pull request. EDIT: Already merged, I just notice. :)

sonora commented 6 years ago

PS: Maybe the solution could be to be a little creative and just pronounce in Czech "Attention, slow!" or similar?

StenSoft commented 6 years ago

I was thinking of using TRAFFIC_CALMING_BUMP (TRAFFIC_CALMING_HUMP, …) and using sub_atom for matching where you don't need to differentiate the subtypes, that should be pretty straightforward without many changes in the code.

vshcherb commented 6 years ago

@sonora we are starting rewriting all prolog files to javascript in order to support voice navigation on IOS, probably that parameter will be introduced there.

alanorth commented 4 years ago

I was just thinking about this while I was driving around with OsmAnd version 3.5.5 on Android. It's very strange for the TTS to announce "Attention, traffic calming" as this doesn't really mean anything. I know what it is attempting to warn me about because I'm familiar with raw OSM tags, but to a lay person they would be wondering "What the hell is 'traffic calming'?"

Would be a much better experience to say "Speed hump" or "Speed bump" in my opinion.

sonora commented 4 years ago

Ok, I have cut over to using "speed bump". Even if not exactly all "traffic calming" methods are speed bumps technically, most of them are close, so we can probably resort to using "speed bump".

phaerrax commented 4 years ago

At least near where I live, a lot of roundabout flares are mapped as traffic_calming=island (OSM Wiki also suggests using it in this case), so I hear "Attention: speed bump" whenever I'm approaching a roundabout tagged as such, but clearly there is no speed bump. While agree that most traffic calming methods are similar to speed bumps, a traffic island is not even close.

sonora commented 4 years ago

So what could be a better wording?

phaerrax commented 4 years ago

Honestly I can't think of one right now. I would back OP's proposal to differentiate between different values of traffic_calming.

ireun commented 10 months ago

Is it still a thing? @vshcherb On weblate service i can see this:

image If this is only for POI couldn't it be used also in TTS?

Ale we are still missing a phrase for traffic_calming=island..