osmandapp / OsmAnd

OsmAnd
https://osmand.net
Other
4.64k stars 1.01k forks source link

Add diaper changing table as POI category #5695

Open ltog opened 6 years ago

ltog commented 6 years ago

I'd like to have the possibility to search for diaper changing tables as a POI category. That should work identically to searching for e.g. libraries: Tapping the magnifying glass symbol, entering library (or diaper in my case) and seeing the results highlighted as orange markers.

As far as I could understand, https://github.com/osmandapp/Osmand/issues/2820 is not a duplicate, but talks about the key diaper=* being visible when tapping a given object and then tapping the "Description" button.

vshcherb commented 6 years ago

I'm not sure what combination of the tag could be considered, it could be combination of any tag like "toilets" or "gas_station", so it is confusing which objects you will be looking for

scaidermern commented 6 years ago

I guess the actual POI type doesn't really matter when being in need for this. Displaying all POIs with diaper=* (except for diaper=no) should be a reasonable approach.

ltog commented 6 years ago

I guess the actual POI type doesn't really matter when being in need for this. Displaying all POIs with diaper=* (except for diaper=no) should be a reasonable approach.

That's exactly my point of view too.

scaidermern commented 6 years ago

Unfortunately there are two tags to look out for: diaper=* and toilets:changing_table=yes.

ltog commented 6 years ago

@scaidermern: Good catch! However, according to Taginfo toilets:changing_table= is nearly unused.

https://taginfo.openstreetmap.org/search?q=toilets%3Achanging_table : 104 Usages https://taginfo.openstreetmap.org/search?q=diaper : 8166 Usages

ltog commented 6 years ago

I was having a look into the source code. The tag toilets:changing_table=yes seems to be taken care of at https://github.com/osmandapp/OsmAnd-resources/blob/80bac2703736f0012292d8b53b3f05410a451614/obf_creation/rendering_types.xml#L4933-L4934 by converting this tag to diaper=yes or diaper=no as far as I could understand.

I found https://github.com/osmandapp/OsmAnd-resources/blob/80bac2703736f0012292d8b53b3f05410a451614/poi/poi_types.xml#L429-L432 and assume these lines will be used to show POI information when looking at the details of one specific POI. This is not what I am looking for.

I guess one would need to create an additional POI type, e.g. in <poi_category name="service"> at https://github.com/osmandapp/OsmAnd-resources/blob/80bac2703736f0012292d8b53b3f05410a451614/poi/poi_types.xml#L3292 something like

<poi_type name="diaper" tag="diaper" value="...">

?

How do you assure all values except no are found? Using

<poi_type name="diaper_yes" tag="diaper" value="yes">
<poi_type name="diaper_1" tag="diaper" value="1">
<poi_type name="diaper_2" tag="diaper" value="2">
<poi_type name="diaper_3" tag="diaper" value="3">
<poi_type name="diaper_4" tag="diaper" value="4">
<poi_type name="diaper_5" tag="diaper" value="5">
<poi_type name="diaper_room" tag="diaper" value="room">

?

Is there a documentation or schema for the poi_types.xml file?

vshcherb commented 6 years ago

I took a look as well, poi_additional means it is not a separate category but it is indexed and searchable. Though you need to configure filter in category service or in toilets for example. So it is an additional information and not POI itself.

bkil commented 5 years ago

There is an ongoing proposal to enhance tagging of baby changing tables. Please share with whoever may be concerned and feel free to comment: https://wiki.openstreetmap.org/wiki/Proposed_features/baby_changing_tables

midnightcomm commented 4 years ago

I would really appreciate being able to find a changing table for diapers/nappy. Either by searching POIs for "changing table", or finding "Toilets" and having a filter for "changing table".

Often places that have a changing table will only have them in the women's room, which as a father can be difficult. Being able to select the location of a changing table by male,female,unisex rooms would be useful to me, but may prove excessively complicated to the average user.