osmandapp / OsmAnd

OsmAnd
https://osmand.net
Other
4.73k stars 1.03k forks source link

Vector maps render layer=-1 features as dashed even if there's no tunnel=* #606

Closed vincentdephily closed 10 years ago

vincentdephily commented 10 years ago

OSMAnd renders some features with a dashed style when they have a layer=-1 tag, even if there isn't a tunnel tag or anything indicating that the feature is somehow covered.

Trunk example: http://osm.org/go/esy4UoA1 River example: http://osm.org/go/esyyzX0f0- Layer tag: http://wiki.openstreetmap.org/wiki/Key:layer

While the tagging in those examples is a bit unusual (it's not mine), it isn't wrong (there's no point in changing it unless you're also doing other changes in the area).

vshcherb commented 10 years ago

We usually don't use github for issues, but you q is very clear. So, I don't see a big issue here, though I agree according to documentation it should not be dashed. You should take into account that OsmAnd uses simplified rendering style and combines all tunnel/layer tags into 1. Particularly here layer="0" and layer="1" looks more logical, so I would say it is a small map defect for OsmAnd.

sanderd17 commented 10 years ago

According to the documentation, it is wrong to tag a way in a cutting as "layer=-1"

http://wiki.openstreetmap.org/wiki/Key:layer

Roads, railways, waterways etc. should not be tagged with a layer just because they are raised up on an embankment or are in a cutting - use embankment http://wiki.openstreetmap.org/wiki/Key:embankment= and cutting http://wiki.openstreetmap.org/wiki/Key:cutting=, respective waterway http://wiki.openstreetmap.org/wiki/Key:waterway=ditch http://wiki.openstreetmap.org/wiki/Tag:waterway%3Dditch for this purpose.

2014-04-13 22:15 GMT+02:00 vshcherb notifications@github.com:

Closed #606 https://github.com/osmandapp/Osmand/issues/606.

— Reply to this email directly or view it on GitHubhttps://github.com/osmandapp/Osmand/issues/606 .

vincentdephily commented 10 years ago

Where should bugs be reported ? I looked on osmand.net and in the FAQ but didn't find any specific info. Did you close the github issue but reopen it somewhere else ?

AFAICS, the mapper didn't use "layer=-1" to mean "cutting" or "embankement" (otherwise he'd have tagged different stetches of the road), but just to distinguish which feature (road, bridge, tunnel, etc) is on top of another, which is the correct use of the tag.

He didn't follow best-practice an common idioms (don't tag layer=0 explicitly, tag the shorter of two overlaping ways, tend to use < 0 for tunnels/culverts and > 0 for bridges, etc), but his tagging isn't "wrong", and OSMAnd should render it properly.

vshcherb commented 10 years ago

We have Google Groups from where "master" members repost them to internal bug tracker. But you can find it if you really want to see on googlecode.