osmandapp / OsmAnd

OsmAnd
https://osmand.net
Other
4.64k stars 1.01k forks source link

POIs should be recognized by mapped key #7873

Open airon90 opened 4 years ago

airon90 commented 4 years ago

There is a wrong translation of kindergarten (amenity=kindergarten) in Italian language. Instead of "asilo nido", somebody translated it as "parco giochi", which is the same translation of playground (leisure=playground). I mapped a kindergarten and OsmAnd says that it was a playground, even when editing the POI, showing an non-existent key "leisure=playground" intead of already-set key amenity=kindergarten. If I switch language of Android to English everything is shown correctly.

I suppose that OsmAnd automatically recognise POIs by the translated key instead of by mapped key and I think that this is a kind of bug. Meanwhile the key for kindergarten has been changed.

vshcherb commented 4 years ago

Not clear whether we should change translation in it/phrases.xml or do something else

airon90 commented 4 years ago

Translation has been obviously changed.

OsmAnd should not check what an item is by the translation key but by keys. I know it is simpler to be implemented but if a translation key is wrong or is equal to another one, OsmAnd cannot correctly represent the item.