search

osmbe / road-completion

Compare open-data road datasets to OpenStreetMap data
https://osmbe.github.io/road-completion/
MIT License
16 stars 3 forks source link

Take in account proposed:highways #449

Open joostschouppe opened 1 year ago

joostschouppe commented 1 year ago

This road was added to OSM a while ago: https://www.openstreetmap.org/way/1020654834/history It's just a road to be constructed, the gov data shouldn't show it as an existing road (probably, the imagery might be outdated of course). So there's tasks in the area, eg https://maproulette.org/challenge/24090/task/196995041

jbelien commented 11 months ago

Shouldn't be an issue! What's the exact tag you want to include ? Here is where the logic happens (for Flanders): https://github.com/osmbe/road-completion/blob/master/data/netherlands/netherlands.sh#L18-L25

joostschouppe commented 11 months ago

Just like you now include highway=, I'd suggest including all proposed:highway= objects. Possibly the same for construction:highway=* One downside is that if we have a proposed/construction highway in OSM already, and the external data correctly evolves from construction to existing road, we wouldn't detect that change. We could exclude all of the proposed/construction highways on the OSM side to fix that, but in Flanders that would give us an issue because so many roads in their dataset are mapped as "existing" when they are really only just proposed. The fact of the matter is we treat highway=construction and highway=proposed differently or not in the future, it makes no sense to treat proposed:highway differently from highway=proposed. So for now I'd say we should indeed add them.