search

osmc / osmc

OSMC (Open Source Media Center) is a free and open source media center distribution
https://osmc.tv
GNU General Public License v2.0
1.65k stars 390 forks source link

NextPVR client doesn't parse genres fully #372

Closed graham8 closed 6 years ago

graham8 commented 7 years ago

NextPVR client on RPi2 does not read iGenreType. It does read sGenre. iGenreType is either 0 or 256. Note on Windows, NextPVR client reads iGenreType but not sGenre (but genre names are correctly displayed). Both using NextPVR client 2.4.13. gromgsxr reports LibreELEC works as expected, suggesting something odd in the compile process?

Affects display of epggrid in skins which support genre colours and FWIW, means genres are not given in the user's language as 256 signals 'get genre strings from backend'.

epg11 nextpvr osmc

epg11 nextpvr win10

samnazarko commented 7 years ago

Wait for 17.3 and let me know if the problem persists

graham8 commented 7 years ago

Yes it does persist. No change.

ActionAdam commented 7 years ago

Impossible! 17.3 has not been released for OSMC.

graham8 commented 7 years ago

Well, I've got it - maybe because I forgot to turn off the staging repo after 4.9 kernel upgrade. Will try again later.

samnazarko commented 7 years ago

17.3 is in the staging repository.

We're not making any changes to this binary add-on, so I wonder if it's a change upstream.

graham8 commented 7 years ago

Do you just get the binary from somewhere else or compile it? I haven't checked gromsxr's claim that it works in LE but suppose their .so should be the same as yours. let me have a look the next time it rains - too nice to be indoors.

samnazarko commented 7 years ago

We compile it when building Kodi.

It's picked from upstream Kodi binary addon repos.

graham8 commented 7 years ago

Update: Had a quick look at LE. All the pvr addons have a .1 suffix to their versions in the repo listing but not to their binaries ie the binary is still pvr.nextpvr.so.2.4.13. But it's not the same size as the osmc one. I couldn't test it - gave up when I couldn't even get LE to ping the NextPVR server.

samnazarko commented 7 years ago

@graham8 Is this still an issue?