search

osmc / osmc

OSMC (Open Source Media Center) is a free and open source media center distribution
https://osmc.tv
GNU General Public License v2.0
1.64k stars 390 forks source link

Raspberry Pi3: Please add kernel module for HyperPixel 4 touchscreen support #621

Open Coren opened 3 years ago

Coren commented 3 years ago

Ahoy!

I've done some digging about HyperPixel4 touchscreen support for OSMC.

There are two changes needed : 1) Install RPi.GPIO (apt-get install python-rpi.gpio works) 2) Enable Goodix Touchpad driver module.

Is it possible to add RPi.GPIO package and enable Goodix support as a builtin/module? Should be a one-line change to the relevant kernel configs:

CONFIG_TOUCHSCREEN_GOODIX=m

Cheers!

samnazarko commented 3 years ago

Hi!

I'd be happy to accept a PR to enable your touchpad module. Can you open it for both kernel configs (Pi2/3/3+ and Pi4)?

I don't think it's a good idea for us to ship RPI.GPIO, because as you can see yourself it's trivial to install. I'd expect most people using GPIO will be comfortable with installing the support via the CLI.

Have you checked to see if the latest (5.10) kernel that we are shipping in Kodi v19 test builds has this included? We recently synchronised our kernel configs up with Pi-OS (upstream), so support may be there already. I can check later.

Coren commented 3 years ago

Here it is.

Coren commented 3 years ago

@samnazarko Is this PR ok for you ? I opened it only for Pi2/3/3+ since Pi4 already have this module enabled.

samnazarko commented 3 years ago

Hi – have you actually checked if this is missing in the latest kernel?

We are currently on a 5.10.x kernel for RBP and your PR is for the older 4.19 kernel. The PR also updates the wrong kernel config – that configuration is for the now deprecated Pi0/1.

You can test the 5.10 kernel by grabbing a Kodi v19 test build from the forums. If it’s there in the Pi 4 config, it should be there for Pi2/3 as well.

Many thanks,

Sam

From: Loiseleur Michel @.> Reply-To: osmc/osmc @.> Date: Thursday, 6 May 2021 at 14:19 To: osmc/osmc @.> Cc: Sam Nazarko @.>, Mention @.***> Subject: Re: [osmc/osmc] Raspberry Pi3: Please add kernel module for HyperPixel 4 touchscreen support (#621)

@samnazarkohttps://github.com/samnazarko Is this PR ok for you ? I opened it only for Pi2/3/3+ since Pi4 already have this module enabled.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/osmc/osmc/issues/621#issuecomment-833516056, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAHDWLDIET7NROXDILDXWG3TMKJMNANCNFSM43CCPVUA.