ka2ddo
commented
2 years ago Here's the terminal output from the latest run. Note the warnings at the end.
[x@y osm-downloads]$ ~/git/osmcoastline/build/src/osmcoastline_filter -o planet-221121-coast.osm.pbf planet-221121.osm.pbf [x@y osm-downloads]$ osmcoastline -o coastline.db -f -g "ESRI Shapefile" -m 30000 -v --bbox-overlap 0 --output-polygons=water planet-221121-coast.osm.pbf [ 0:00] Started osmcoastline version 2.3.1 (v2.3.1-6-g5652a7b-changed) / libosmium version 2.18.0 [ 0:00] Using SRS 4326 for output. (Change with the --srs/s option.) [ 0:00] Writing to output database 'coastline.db'. (Was set with the --output-database/-o option.) [ 0:00] Removing database output file (if it exists) (because you told me to with --overwrite/-f). [ 0:00] Will create geometry index. (If you do not want an index use --no-index/-i.) [ 0:01] Reading from file 'planet-221121-coast.osm.pbf'. [ 0:01] Reading ways (1st pass through input file)... [ 0:14] There are 2 nodes where the coastline is not closed. [ 0:14] There are 722705 coastline rings (696749 from a single closed way and 25956 others). [ 0:14] Memory used: current: 3238 MBytes, peak: 3341 MBytes [ 0:14] Reading nodes (2nd pass through input file)... [ 1:08] Checking for missing locations... [ 1:08] All locations are there. [ 1:12] Memory used: current: 6740 MBytes, peak: 6740 MBytes [ 1:12] Check line segments for intersections and overlaps... [ 2:52] Trying to close Antarctica ring... [ 2:52] Closed Antarctica ring. [ 2:52] Close broken rings... (Use --close-distance/-c 0 if you do not want this.) [ 2:52] Closing if distance between nodes smaller than 1. (Set this with --close-distance/-c.) [ 2:52] Closed 0 rings. This left 0 nodes where the coastline could not be closed. [ 2:52] Not writing out rings. (Use option --output-rings/-r if you want the rings.) [ 2:52] Create polygons... [ 6:39] Fixing coastlines going the wrong way... [ 6:39] Turned 3 polygons around. [ 6:39] Not writing coastlines as lines (Use --output-lines/-l if you want this). [ 6:39] Checking for questionable input data... [ 6:40] Found 6 rings in input data. [ 6:40] Split polygons with more than 30000 points... (Use --max-points/-m to change this. Set to 0 not to split at all.) [ 6:40] Using overlap of 0 (Set this with --bbox-overlap/-b). Polygon split at depth 1 was not successful. Keeping un-split polygon. Polygon split at depth 3 was not successful. Keeping un-split polygon. [24:58] Checking and making polygons valid... [26:20] Writing out water polygons... [186:48] Memory used: current: 6740 MBytes, peak: 8788 MBytes [186:48] Committing database transactions... [186:48] All done. [186:48] Memory used: current: 6740 MBytes, peak: 8788 MBytes There were 1128 warnings. There were 0 errors. [x@y osm-downloads]$
joto
When running osmcoastline on the current planet-NNNNNN.osm.pbf files to produce water polygons, the resulting data has many invalid ESRI polygons of type zero (instead of the type 3 or 5 that seem to be valid). It doesn't matter whether I have osmcoastline generate the SQLite database and then convert the DB to ESRI shapefile with ogr2ogr, or have osmcoastline generate ESRI shapefiles directly. This results in large swaths of ocean not being "wet" (in obvious rectangular stripes) upon rendering the remaining valid polygons; such missing polygons appear in the Sulu Sea and the Bering Sea (among other places).
Platform is Intel CPU running Fedora Core 34 (64-bit version), latest git pull of osmcoastline and libosmium as of 2022-Nov-28, gdal 3.2.2-3. However, this problem has been apparent for the last year (may have been longer, but not previously logged by the application that subsequently reads the Shapefile).