search

osmfoundation / welcome-mat

This is the code for the OpenStreetMap Welcome Mat website
https://welcome.openstreetmap.org/
14 stars 13 forks source link

https://welcome.osm.org/ shows sports gambling site instead?? #84

Closed mnalis closed 1 year ago

mnalis commented 1 year ago

Rationale: People are expecting that shorted osm.org domain works the same as longer openstreetmap.org (e.g. wiki.osm.org, osm.org, tile.osm.org, etc).

However, that assumption breaks when I tries to open welcome mat site using welcome.osm.org instead of welcome.openstreetmap.org.

While welcome.openstreetmap.org works normally as expected: small_welcome openstreetmap org

Using shorted welcome.osm.org however opens this (Seems to be sports gambling site in Indonesian language or something): small_welcome osm org

I find it as a problem which should be fixed. Ideally in the way so https://welcome.osm.org works the same as https://welcome.openstreetmap.org. (failing that, at should visiting the page should throw an error instead of showing random hacked-looking content)

I've tried asking OSM Operations, and they indicated it is probably because while both DNS servers point to same IP, the web server has only welcome.openstreetmap.org name registered, and should have welcome.osm.org registered too, so I should report here. They are however not sure if registering more than one name is even possible on github pages where Welcome mat is allegedly hosted.

So, could something be done about that?

I've only found somewhat related https://github.com/osmfoundation/welcome-mat/issues/40 (while also bad, certificate warning was maybe little better that showing random gambling site under official osm.org domain)

danieldegroot2 commented 1 year ago

cc: @Firefishy

Firefishy commented 1 year ago

:-( The site uses GitHub Pages and multiple domains are not supported.

Firefishy commented 1 year ago

I will fix the issue over next day or 2.

craigallan commented 1 year ago

My 2cents on the github multiple domain problem... Delete the A and AAAA records for welcome.osm.org welcome.osm.org CNAME welcome.openstreetmap.org

Firefishy commented 1 year ago

My 2cents on the github multiple domain problem... Delete the A and AAAA records for welcome.osm.org welcome.osm.org CNAME welcome.openstreetmap.org

We use code to manage all our domains. For ease of management, all OpenStreetMap domains use the same config. While we could likely code in specific handling to drop the osm.org records, it would likely be better to fix the issue in another way.

Firefishy commented 1 year ago

I have temporarily disabled the invalid DNS records in https://github.com/openstreetmap/dns/commit/996105ef5d12d65f3afd10022934284bb3e81bdb until ultimate fix is deployed: https://github.com/openstreetmap/chef/pull/566

Firefishy commented 1 year ago

Fixed now.