search

osmium-org / osmium

Online collaborative fitting tool.
https://o.smium.org/
GNU Affero General Public License v3.0
76 stars 25 forks source link

Fixed #173 #174

Closed unti1x closed 6 years ago

unti1x commented 7 years ago

Fixed link to point to revision

Artefact2 commented 7 years ago

Thanks for the (simple) fix. Add your name to the copyright header & I can merge this. Also, please don't reference issue numbers in commit messages (use a more descriptive commit name).

unti1x commented 7 years ago

I don't think this fix is enough to add my name to copyright. =D

Actually, issue reference is a common practice in github, 'couse it allows you to close issues with pr (https://github.com/blog/1506-closing-issues-via-pull-requests)

Artefact2 commented 7 years ago

I don't think this fix is enough to add my name to copyright. =D

Copyright is tricky, I don't want to take any potential risks.

Actually, issue reference is a common practice in github, 'couse it allows you to close issues with pr

If the project ever moves away from github (or someone wants to fork or host a mirror somewhere else, or someone just uses git log) all context will be lost and you'll be left with a bunch of useless commit messages.

Sorry if I sound rude, I really enjoy you taking the time to contribute.

unti1x commented 7 years ago

Got it. Gonna fix these as soon as possible

unti1x commented 7 years ago

Done. Let me know if I have to change anything else.

Artefact2 commented 6 years ago

Cherry-picked into v0.13.5-hotfixes as 4160b22b5a8a84b8c79b02ab27ba2d9dcebacc95.