osmlab / atlas-checks

OSM data integrity checks with Atlas
BSD 3-Clause "New" or "Revised" License
57 stars 83 forks source link

[Fix Suggestions] AddressStreetNameCheck to consider abbreviations #597

Open herriotto opened 3 years ago

herriotto commented 3 years ago

AddressStreetNameCheck in Venezuela market has tags addr:street=Av.5 which refers to 'Avenida 5', such as here - https://maproulette.org/challenge/18614/task/95888925

another example is addr:street=Av. Bolivar, referring to 'Avenida Bolivar' identified in the AtlasCheck here - https://maproulette.org/challenge/18614/task/95891518

Are abbreviations considered/under discussion for this check?

Bentleysb commented 3 years ago

Hi @herriotto. The check does not currently consider abbreviations at all, and as far as I'm aware this is the first discussion of it. The point of the check is to make sure that the address and surrounding name tags match, which includes identifying typos and such. So I would think that it is legitimate to flag addresses and street names that are not abbreviated in the same manor.

Bentleysb commented 3 years ago

Actually, I take back my statement about this being the first discussion about abbreviations in AddressStreetNameCheck. I forgot about the discussion here: https://github.com/osmlab/atlas-checks/issues/409 There it has been discussed adding a standardization library to help deal with abbreviations. However, in that case it was for creating suggested fixes.

vladlemberg commented 2 years ago

@Bentleysb, please assign this task to me.

atiannicelli commented 2 years ago

@herriotto , please close as this was merged and solved.