SeparateSidewalkTagCheck [New Atlas Check]

[vladlemberg]

Description:

A check to validate that when sidewalk=* tags are used on a highway that any separately mapped sidewalk(s) are consistent with the highway’s sidewalk tags. Please refer to requirements and use cases: https://github.com/osmlab/atlas-checks/issues/653

Potential Impact:

Update Atlas version to 6.6.1.

Unit Test Approach:

Simulate true positive and false positive cases.

Test Results:

ISO	Total Flags	Sampled	Sampling %	TP	FP	False Positive Rate
USA	3575	204	5.7%	190	14	6.9%

[vladlemberg]

Hello Everyone, I believe SeparateSidewalkCheck is ready for review. Few things:

1) I was unable to create a unit tests for alternative sidewalk mapping: sidewalk:left and sidewalk:right cases. Those tags were introduced in 6.6.1 Atlas version. Perhaps unit test suite can't understand these tags. Example: invalidHighwayRightSidewalkLeftAlternativeMapping;

2) Check was tested against USA region only.

[vladlemberg]

@Bentleysb, @atiannicelli I'm confirming that unit tests for alternative Sidewalk mapping is broken because of new tags "sidewalk:left" and "sidewalk:right". I believe something is wrong with creating test atlas with new tags. I'm proposing to remove alternative sidewalk mapping for this PR. What would you suggest ?

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

89.5% Coverage
0.0% Duplication

[pscrimshaw]

@atiannicelli please feel free to review when you get the chance. Thank you!