osmlab / atlas-checks

OSM data integrity checks with Atlas
BSD 3-Clause "New" or "Revised" License
57 stars 82 forks source link

MapRoulette Challenge isArchived #660

Closed Bentleysb closed 2 years ago

Bentleysb commented 2 years ago

Description:

This adds the isArchived field to the Challenge class, and adds it as a value in the challenge json. For now it is set to always be false, as challenges must be unarchived for tasks to be uploaded to them through the API. This will cause any archived challenges to be unarchived by the MapRouletteUploadCommand before it attempts to upload tasks to the given challenges. This is useful for dealing with the new challenge auto-archiving after 6 months of inactivity.

Potential Impact:

Challenges will be unarchived by the MR Upload command before attempting to upload tasks to them.

Unit Test Approach:

Added the new field in the serialization unit test.

Test Results:

Tested uploading to an archived challenge before and after this change. Before, the challenge remained archived and no tasks were uploaded. After, the challenge was unarchived and tasks were uploaded as expected.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

pscrimshaw commented 2 years ago

@atiannicelli please feel free to review whenever you get the chance!