search

osmlab / awesome-openstreetmap

😎 Curated list of awesome OpenSteetMap-projects
Creative Commons Zero v1.0 Universal
664 stars 60 forks source link

Update README.md #93

Closed joelotz closed 2 years ago

joelotz commented 2 years ago
Unkn0wnCat commented 2 years ago

Thanks for the PR! The Android Links are a really welcome addition! 🎉

Unkn0wnCat commented 2 years ago

A few hints considering you've said you're new to creating PRs:

  1. Consider splitting PRs such as this one into two, each one only doing one thing. Then you can title the PR with the change (e.g. "Add OSM Go!" or "Add links to Google Play"). This will allow for nicer readability of the commit log!
  2. You can use the "Closing"-keyword in front of a Issue number (e.g. "Closing #76") to automatically have that issue close on merge
  3. Consider customizing your commit messages, much like for the PR titles. Try to keep it short and in the imperative like "Add OSM Go!", "Rework Links", or "Add Google Play Links"

Hope this helps! 😃

joelotz commented 2 years ago

Great feedback, thanks!

On Fri, 27 May 2022 at 1:14 AM, Kevin Kandlbinder @.***> wrote:

A few hints considering you've said you're new to creating PRs:

  1. Consider splitting PRs such as this one into two, each one only doing one thing. Then you can title the PR with the change (e.g. "Add OSM Go!" or "Add links to Google Play"). This will allow for nicer readability of the commit log!
  2. You can use the "Closing"-keyword in front of a Issue number (e.g. "Closing #76 https://github.com/osmlab/awesome-openstreetmap/issues/76") to automatically have that issue close on merge
  3. Consider customizing your commit messages, much like for the PR titles. Try to keep it short and in the imperative like "Add OSM Go!", "Rework Links", or "Add Google Play Links"

Hope this helps! 😃

— Reply to this email directly, view it on GitHub https://github.com/osmlab/awesome-openstreetmap/pull/93#issuecomment-1138945641, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABMHQK75ESNC6ULHUEVZPDVL7IDLANCNFSM5W3Q64NQ . You are receiving this because you authored the thread.Message ID: @.***>