osmlab / changeset-map

Visualise a changeset on a map
http://osmlab.github.io/changeset-map/
ISC License
34 stars 12 forks source link

Unable to view tag differences of a highway #115

Closed ramyaragupathy closed 7 years ago

ramyaragupathy commented 7 years ago

Here is a way on OpenStreetMap, for which highway key has been changed from unclassified -> tertiary. This is part of Changeset - 46620937.

This way can be visualised on changeset-map with this link http://osmlab.github.io/changeset-map/#46620937/way/478825377.

But once deselected, way disappears. There's no way to look at this highway again. Ideally I expect a pop up with the tag difference listed. changeset

cc @ajithranka @geohacker

ramyaragupathy commented 7 years ago

Similar case http://osmlab.github.io/changeset-map/#47023035/node/3291970806, but here node is not highlighted at all.
OpenStreetMap history: https://www.openstreetmap.org/node/3291970806/history

bsrinivasa commented 7 years ago

Adding a similar case here. http://osmlab.github.io/changeset-map/#46728124/way/5671661 The changeset map stops responding after an initial pan or zoom.

OSM Link: http://www.openstreetmap.org/way/5671661

bsrinivasa commented 7 years ago

http://osmlab.github.io/changeset-map/#39563991/way/46130066

OSM link: https://www.openstreetmap.org/way/46130066/history#map=17/40.80752/-73.92463

ajithranka commented 7 years ago

Case 1

#46620937/way/478825377

Case 2

#47023035/node/3291970806

#46728124/way/5671661

Case 3

#39563991/way/46130066

cc: @batpad @geohacker

geohacker commented 7 years ago
ajithranka commented 7 years ago

PR #121 should fix case 1 and case 3 errors. @ramyaragupathy @bsrinivasa, please cross-check and confirm. If 👍, I'll publish to npm.

ramyaragupathy commented 7 years ago

Looks good to me @ajithranka 🙇‍♀️

ajithranka commented 7 years ago

Fixed. No next actions.