search

osmlab / changeset-map

Visualise a changeset on a map
http://osmlab.github.io/changeset-map/
ISC License
34 stars 12 forks source link

Dates should be expressed in ISO-8601 format #166

Open b-jazz opened 6 years ago

b-jazz commented 6 years ago

Brief Description

When entering dates in the filter for thanksgiving to christmas, 11/23/2017 -> 12/25/2017 doesn't work because it expects a format that is specific to a particular region of the world that I'm not familiar with. It would be much better if YYYY-MM-DD format was used for the dates since that is a clear, international standard for representing dates.

What is the current behaviour, (attach relevant screenshots) ?

What is the expected behaviour ?

When does this occur ?

How do we replicate the issue ?

1. 2. 3. 4.

Please tell us about your environment:

Other Information / context:

willemarcel commented 6 years ago

Hi @b-jazz

Thank you for your report! Are you trying to filter the edits using OSMCha, right?

batpad commented 6 years ago

Thanks for the report @b-jazz -- @willemarcel the date format seems to be defined and hard-coded here: https://github.com/mapbox/osmcha-frontend/blob/master/src/components/filters/date.js#L50

I would definitely be in favour of either adapting to user's locale or following a more standard YYYY-MM-DD. Obligatory xkcd

b-jazz commented 6 years ago

@illemarcel that's correct, on the filter page. @batpad thanks for clarifying and including the perfect XKCD.