search

osmlab / changeset-map

Visualise a changeset on a map
http://osmlab.github.io/changeset-map/
ISC License
34 stars 12 forks source link

Add Zoom Navigation Control to the map #189

Closed tordans closed 4 years ago

tordans commented 5 years ago

Zooming on a desktop is not a problem, but on a touch device one is helpless without the NavigationControls which are added here.

Documentation: Example https://docs.mapbox.com/mapbox-gl-js/example/navigation/ Config https://docs.mapbox.com/mapbox-gl-js/api/#navigationcontrol

I could not test this locally. I have the system active now, but the bundle.js is not refreshed on my system, so the changes in this file never showed in my browser. However, its a simple change so I hope it will just work. Please test it before considering a merge.

This is a step to improve https://github.com/mapbox/osmcha-frontend/issues/341 once it is added to the osmcha-frontend.

tordans commented 4 years ago

@willemarcel why you are active here (https://github.com/osmlab/changeset-map/pull/202), I would love to see those zoom controls in the app to improve the mobile and iPad experience.

willemarcel commented 4 years ago

Merged with https://github.com/osmlab/changeset-map/pull/204

willemarcel commented 4 years ago

Thank you very much, @tordans ! Sorry for the delay... I added a check to show the zoom control only if the device is touchscreen and doesn't have a mouse. We'll update osmcha tomorrow. Let me know if it works for you

willemarcel commented 4 years ago

@tordans it's already live on osmcha.org