search

osmlab / changeset-map

Visualise a changeset on a map
http://osmlab.github.io/changeset-map/
ISC License
34 stars 12 forks source link

Changeset-map shows changes not from the selected changeset #267

Open NeatNit opened 2 months ago

NeatNit commented 2 months ago

Brief Description

When trying to view the changes in one changeset, I see both its changes and changes from another changeset.

What is the current behaviour, (attach relevant screenshots) ?

More than just the changes in the selected changeset are shown. The following changeset has just 3 deleted nodes and nothing else: https://www.openstreetmap.org/changeset/156004633 image But viewing the same changeset on changeset-map or OSMCha produces a busy map: https://osmlab.github.io/changeset-map/#156004633 image

What is the expected behaviour ?

Only changes from the selected changeset are shown

When does this occur ?

Possibly when the same user makes changes in another newer changeset while the first changeset is still open

How do we replicate the issue ?

I don't want to start making false edits to the map, so this is a guess:

  1. Open a changeset, make some changes, do not close the changeset
  2. Open a new changeset, make more changes in the same area (within the bounding box of the previous changeset), close the new changeset
  3. Close the first changeset
  4. View the first changeset in changeset-map

Please tell us about your environment:

Firefox 129.0, Linux Mint

Other Information / context:

This scenario was caused by a bug in my import code that caused a crash while the changeset was still open, so it was never closed. After fixing that bug I ran the code again to complete the rest of the changes. Only then I closed the original changeset, hoping to see it in OSMCha.

tordans commented 2 months ago

Is this a duplicate of https://github.com/osmlab/changeset-map/issues/102