osmlab / editor-layer-index

A unified layer index for OSM editors.
https://osmlab.github.io/editor-layer-index/
Other
220 stars 258 forks source link

GRAFCAN is better in the canary islands than PNOA - add a "best" flag for it? #731

Closed JonasCz closed 4 years ago

JonasCz commented 4 years ago

I've noticed that "GRAFCAN - Canary Islands" is better than "PNOA Spain" in the Canary islands, since it's much sharper (higher resolution). Maybe it'd be possible to add the "best" flag to it, so that editors will use it by default? (Not entirely sure how that works, so no pull request...)

For reference, here's a comparison screenshot (click for full-res):

GRAFCAN:

GRAFCAB

PNOA:

PNOA

Thanks;

grischard commented 4 years ago

Hello! So GRAFCAN is a local layer, and PNOA covers all of Spain? PNOA might already be tagged as best because it's better than the other choices for the rest of Spain. We could tag the two as 'best', but the behaviour then depends on the editors.

See also #691, #130, #390 and for a potential way forward #586

JonasCz commented 4 years ago

Yep, exactly - GRAFCAN is local for the canary islands only, but it's better there.

With both tagged as "best" iD chooses the smaller area one first (i think?), so that seems like it would yield good results for at least iD users.

grischard commented 4 years ago

Ok, let's try and see :). Do you want to PR this?

JonasCz commented 4 years ago

PR is here: https://github.com/osmlab/editor-layer-index/pull/732

I think I got the JSON right, but please check.

grischard commented 4 years ago

Merged in 9adac880a898ff2f6dd9acbf5893cf12e8cb5b70, thank you!