osmlab / field-data-collection

A mobile application for collecting both OSM & private data in the field.
10 stars 7 forks source link

Adding profile info to observations #194 #246

Closed kamicut closed 7 years ago

kamicut commented 7 years ago

Done:

Questions/TODOs:

  1. In the profile view, "save" doesn't redirect anywhere, so there's no user feedback. Any suggestions here?
  2. What should userName and userEmail be by default? Right now they're empty strings ''. Should the tags userName and userEmail be saved if there is no profile info?
  3. If the profile info changes, we can't associate old observations with the profile info, but the device id doesn't change. I think this is fine for the purpose of displaying a name / email since the device id is the ground truth, but would like to hear your thoughts
  4. @felskia I tried but I couldn't get the button to stick to the bottom, would like your help here :)
sethvincent commented 7 years ago
  1. This might be a good place to use the StatusBar. Based on the action type, you can show a message in the statusbar. Check out this reducer for adding messages: https://github.com/osmlab/field-data-collection/blob/master/app/reducers/status.js

  2. Empty strings seems ok.

  3. Yeah, I think we're expecting the device id to be the unique id.

felskia commented 7 years ago

Fixed the button here. @kamicut @dereklieu the problem is that when I try to bring it back into the coordinator app, the app freezes so I can't determine if the name actually gets carried through to the desktop app

kamicut commented 7 years ago

@seth

kamicut commented 7 years ago

@seth the status bar now shows up. Back to you for review.

sethvincent commented 7 years ago

:+1: