search

osmlab / field-data-collection

A mobile application for collecting both OSM & private data in the field.
10 stars 7 forks source link

update react-native-mapbox-gl: fix android latlng issue #319

Closed sethvincent closed 6 years ago

sethvincent commented 6 years ago

This uses latest changes from my fork of react-native-mapbox-gl.

This closes #254 which allows us to create non-dev-mode builds. Before, creating a build in release mode would mean that when the app hit the issue described in #254, the app would crash and quit without warning as it started up.

Fixing this bug means we can create release builds, which because they are not including development-related functionality, will have better performance.

I couldn't get release builds to work without including the mapbox access token as a string instead of an environment variable. That's something we could look into later.

1ec5 commented 6 years ago

I couldn't get release builds to work without including the mapbox access token as a string instead of an environment variable. That's something we could look into later.

I’m not sure whether it can be adapted to a React Native environment, but one clean approach in a pure Cocoa project is to have a Run Script build phase read the access token from a git ignored file.

sethvincent commented 6 years ago

@1ec5 thanks I'll check that out.