Use locked dataset to reuse standard JOSM UI

osmlab / josm-atlas

JOSM Plugin to visualize Atlas data

BSD 3-Clause "New" or "Revised" License

14 stars 13 forks source link

Use locked dataset to reuse standard JOSM UI #16

Closed don-vip closed 6 years ago

don-vip commented 6 years ago

This PR makes AtlasReaderLayer extends OsmDataLayer in order to benefit from standard JOSM HMI (tags dialog, filters, search, presets, etc.: the list is long).

This relies on the new "locked layer" feature available in JOSM 13500. The underlying dataset is always locked so it cannot be modified in any way.

As an immediate consequence the "tag box" is removed as it is redundant with JOSM tag dialog.

don-vip commented 6 years ago

This solves #9.

jwpgage commented 6 years ago

Thanks @don-vip! Since this removes the tag box from the AtlasReaderDialog, if you select a particular atlas entity from the AtlasReaderDialog does the standard tag box update with the tags for that entity?

hallahan commented 6 years ago

This works great! There's a conflict with the PR I just merged, will resolve and pull in!

don-vip commented 6 years ago

@jwpgage yes the standard tag dialog is used :)