Support "official" examples

osmlab / jsopeninghours

JavaScript opening_hours parser.

7 stars 2 forks source link

Support "official" examples #1

Open tyrasd opened 11 years ago

tyrasd commented 11 years ago

From the list of examples on the wiki the following don't work ( 7 5 out of 10 :-1: ):

~~24/7~~
Mo 10:00-12:00,12:30-15:00; Tu-Fr 08:00-12:00,12:30-15:00; Sa 08:00-12:00
Mo-Su 08:00-18:00; Apr 10-15 off; Jun 08:00-14:00; Aug off; Dec 25 off
Mo-Sa 10:00-20:00; Tu off
~~sunrise-sunset~~
Su 10:00+
week 1-53/2 Fr 09:00-12:00; week 2-52/2 We 09:00-12:00

Also, a list of days like "Mo,Fr 10:00-11:00" doesn't seem to work.

iandees commented 11 years ago

24/7 is supported but not displayed in the tool on the page
Multiple opening hour ranges in a particular day range are not supported
Day-of-month ranges are not supported (only weekday ranges are supported)
"off" is not supported (how is that any different than being closed?)
sunrise-sunset is supported but not displayed in the tool on the page
complicated day ranges with week numbers are not supported
10:00+ should probably be supported but I'll have to come up with a way to represent that in the tool
A list of days should probably be supported, but for now it can be represented as Mo 10:00-11:00; Fr 10:00-11:00.

tyrasd commented 11 years ago

Multiple opening hour ranges in a particular day range are not supported

I'd say this should be supported even in a minimal implementation of opening_hours. (Shops can have midday breaks or restaurants may only open for lunch and dinner.)

"off" is not supported (how is that any different than being closed?)

Just like a list of days, this syntax is used as a short-cut. Mo-Sa 10:00-20:00; Tu off instead of Mo 10:00-20:00; We-Sa 10:00-20:00;.