osmlab / name-suggestion-index

Canonical common brand names, operators, transit and flags for OpenStreetMap.
https://nsi.guide
BSD 3-Clause "New" or "Revised" License
712 stars 877 forks source link

Poczta Polska post office should have `brand` tag rather than `operator` #10028

Closed matkoniecz closed 3 weeks ago

matkoniecz commented 1 month ago

Poczta Polska post offices deserve brand - these are definitely branded.

See say https://pl.wikipedia.org/wiki/Poczta_Polska#/media/Plik:Urz%C4%85d_Pocztowy_w_Niwiskach.jpg

this is typical, often branding is more clear

screen04

And I am not sure is operator always correct - maybe there is franchising somewhere?

Snowysauce commented 1 month ago

This is somewhat related to #9993, where I don't know which tree (brand/operator) that postal network should be in. My only frame of reference as an American is USPS, where the NSI gives the operator (United States Postal Service) priority over the "United States Post Office" brand present on every USPS facility.

matkoniecz commented 1 month ago

In Poland there is no such situation - and I suspect that also elsewhere it is more typical than USA dualism.

Poczta Polska is branded on Poczta Polska post offices. Note that in NSI post offices in Poland have solely operator - while they are branded in reality.

matkoniecz commented 1 month ago

And I suspect that all (or nearly all?) post offices with only operator set should have it as brand

Definitely for this case.

matkoniecz commented 1 month ago

Fixing looks easy. Move https://github.com/osmlab/name-suggestion-index/blob/f585083b1dab44508932afe5701d8bb59c27bd77/data/operators/amenity/post_office.json#L988 to https://github.com/osmlab/name-suggestion-index/blob/f585083b1dab44508932afe5701d8bb59c27bd77/data/brands/amenity/post_office.json

And then wait for release and run that brand-adder bot edit that I planned, maybe I will amend it to also remove that not needed operator

matkoniecz commented 1 month ago

@Snowysauce Snowysauce added the needs discussion label Oct 11, 2024

I can start thread at Polish community forum if anyone feels that it is necessary, but this case seems really simple and obvious to me