search

osmlab / name-suggestion-index

Canonical common brand names, operators, transit and flags for OpenStreetMap.
https://nsi.guide
BSD 3-Clause "New" or "Revised" License
712 stars 875 forks source link

How does the Wikidata script select a Facebook icon? #10116

Closed UKChris-osm closed 1 week ago

UKChris-osm commented 2 weeks ago

While looking at another issue, I noticed that McDonalds is using the South Africa Facebook Logo, which currently doesn't show a meaningful McD's logo.

This isn't an issue as such, as dist_files.js already overrules Facebook to use a Commons Logo, but it did make me wonder why the South African Facebook logo is being chosen by the Wikidata script over the main McDs Facebook, when the main one has a preferred rank.

Is it because the South Africa one is the last in the list, does the Wikidata script not factor in rank?

1ec5 commented 2 weeks ago

The script does prefer any statement with preferred rank, so I’m unsure why that isn’t working:

https://github.com/osmlab/name-suggestion-index/blob/1a86c90de65e20e13b4402fa7264196b4234d6ac/scripts/build_wikidata.js#L507 https://github.com/osmlab/name-suggestion-index/blob/1a86c90de65e20e13b4402fa7264196b4234d6ac/scripts/build_wikidata.js#L334-L335

It’s only showing up now because someone recently dumped a ton of regional statements onto the global McDonald’s item, even though each regional subsidiary already has its own item, including McDonald’s South Africa (Q27923821). I’m tempted to simply revert the changes, but probably the better option would be to move the statements to the appropriate items.

Snowysauce commented 2 weeks ago

NSi.guide seems to be using the main McDonald's Facebook page and logo as of the latest update/release. After seeing that change, I went back and looked at timestamps, and from what I can tell, the previous release was published just after midnight US Eastern time on October 14, and the statement for the main McDonald's Facebook page was changed from normal to preferred rank about 10 hours later. Thus, all the Facebook statements had equal ranks at the time of the previous write to NSI.guide, and the South African Facebook page was indeed chosen because it was the last listed.

UKChris-osm commented 1 week ago

and the statement for the main McDonald's Facebook page was changed from normal to preferred rank about 10 hours later. Thus, all the Facebook statements had equal ranks at the time of the previous write to NSI.guide, and the South African Facebook page was indeed chosen because it was the last listed.

That makes sense, thanks for looking into that @Snowysauce and thanks @1ec5 for you reply too.