search

osmlab / name-suggestion-index

Canonical common brand names, operators, transit and flags for OpenStreetMap.
https://nsi.guide
BSD 3-Clause "New" or "Revised" License
712 stars 875 forks source link

Preserve `name=*` tags of CBA & Reál convenience stores #10132

Closed gy-mate closed 4 days ago

gy-mate commented 1 week ago

The name=* tags of CBA & Reál convenience stores should be preserved, as these shops usually have a unique name by which they are commonly known.

UKChris-osm commented 1 week ago

When you say "smaller" shops, are you still talking about supermarkets, or the "convenience stores"?

I've also noticed the supermarket in Bulgaria is a separate entry from the rest, but this isn't the case for "convenience stores", do you think this should be changed as well?

gy-mate commented 1 week ago

When you say "smaller" shops, are you still talking about supermarkets, or the "convenience stores"?

@UKChris-osm My bad, I meant convenience stores. Fixed the title, description and the content of the PR. (Thank you for the question! A CBA convenience store tagged wrongly as a supermarket misled me.)

gy-mate commented 1 week ago

I've also noticed the supermarket in Bulgaria is a separate entry from the rest, but this isn't the case for "convenience stores", do you think this should be changed as well?

Unfortunately I'm not familiar with Bulgarian CBA stores.

Dimitar5555 commented 1 week ago

I've also noticed the supermarket in Bulgaria is a separate entry from the rest, but this isn't the case for "convenience stores", do you think this should be changed as well?

Yes it should be a separate entry without preserveTags. They are named "CBA". Any other local names (example) are related to the branch.

gy-mate commented 6 days ago

@Dimitar5555 Thank you for the info!

Lke this?

Dimitar5555 commented 5 days ago

Yes, exactly like that. Thanks!

gy-mate commented 5 days ago

@UKChris-osm @Snowysauce I think this is ready for a final review.