search

osmlab / name-suggestion-index

Canonical common brand names, operators, transit and flags for OpenStreetMap.
https://nsi.guide
BSD 3-Clause "New" or "Revised" License
713 stars 860 forks source link

Add entry for: Sodimac #2357

Closed sguinetti closed 5 years ago

sguinetti commented 5 years ago

Sodimac Website Wikipedia brand=Sodimac shop=doityourself

Adamant36 commented 5 years ago

Hi there. I noticed you added a bunch of issues for adding new entries. Do you any experience with coding? If so, there's a guide for how to contribute in the CONTRIBUTING.md. They will probably get added quicker if you add them yourself and we can always use new contributors.

sguinetti commented 5 years ago

Hello.Unfortunately I don't have experience in npm coding. Thanks for asking. Although I know some franchises of Peru and, out of curiosity, I found this Github repository. So I'm adding what I have in my notes.

Adamant36 commented 5 years ago

If you have general coding experience its not that difficult. Adding new entries only takes editing one file and its all pretty uniform. If its not something you want to do though, I guess someone else add them at some point.

Btw, we don't really include websites in the index since they usually be found on the company's Wikidata page. So one thing that might be worth doing on your end if you want is checking that the Wikidata entries have links to the websites and adding them if not. It should be fairly easy.

sguinetti commented 5 years ago

Maybe at another time I will make contributions with this mode of code. For the rest, I hope the review goes well.

sguinetti commented 5 years ago

@Adamant36 Hello again. Is canonical.json this file for editing? If so, I know something about JSON coding (without npm). As I see it is easy to add information (like #2350 right?). Reviewing Marathon Sports #2355, I can add without much mess. Thanks for the suggestion.

matkoniecz commented 5 years ago

https://github.com/osmlab/name-suggestion-index/blob/master/CONTRIBUTING.md should help

If it is not good enough - open an issue with explanation what is unclear

Adamant36 commented 5 years ago

@sguinetti yes it is if your just adding new companies. Id follow @matkoniecz's advice anyway though by going through the guide and opening an issue for anything in it that's not clear. Its always better to read instructions if there are any versus not. Plus, guidelines always need improving :).