bhousel
commented
4 years ago Ok, I did this, but I'm not sure how good it will be.
Internally this library maintains an index of key/value|name matches. I ended up disabling the warnings about name collisions for the *=yes values because this introduced hundreds of name collisions.
For example a feature like amenity/yes|Cosmo could map to either:
"amenity/fuel|Cosmo" or "amenity/restaurant|Cosmo"
We just don't know. iD will probably offer to upgrade it to something, but it might not be the right thing.
If this turns out to be a real problem, I can throw out all the duplicates after the name matching index is built. But then iD won't flag them as issues, which I suppose is the point of all this.
I'll close for now, but we'll keep an eye on this if it causes problems or if there is a better way.
boothym
Reposted from https://github.com/openstreetmap/iD/issues/7197
I came across a node tagged shop=yes and name="Topps tiles". I changed this to shop=tiles and then iD offered to upgrade the tags with brand data.
For shop=yes objects where the name matches* would it be possible for iD to offer to upgrade the tags? This would be useful since these shops can be missed when looking at an area, as they are not otherwise highlighted by iD.
*a case insensitive match would be good