osmlab / name-suggestion-index

Canonical common brand names, operators, transit and flags for OpenStreetMap.
https://nsi.guide
BSD 3-Clause "New" or "Revised" License
705 stars 843 forks source link

Validate/lookup operator:wikidata from brand:wikidata/network:wikidata #4337

Open peternewman opened 3 years ago

peternewman commented 3 years ago

Using the Operator key in the wikidata.

Or is this done already?

bhousel commented 3 years ago

For transit/ subtree I'm considering network/network:wikidata the primary identifying tags.. If there is an operator value that matches the network value, the script will also copy over

This is just based on what I saw looking at how things generally look to be tagged in OSM. I know that the operator is sometimes the same, sometimes something else, so the scripts don't touch the operator:* values if the operator is missing or set to something different.

Does that make sense?

peternewman commented 3 years ago

For transit/ subtree I'm considering network/network:wikidata the primary identifying tags.. If there is an operator value that matches the network value, the script will also copy over

  • network:wikidata->operator:wikidata
  • network:wikipedia -> operator:wikipedia

Ah cool.

This is just based on what I saw looking at how things generally look to be tagged in OSM. I know that the operator is sometimes the same, sometimes something else, so the scripts don't touch the operator:* values if the operator is missing or set to something different.

Does that make sense?

It does.

I was suggesting that you could also query Wikidata to see if this is set on the network: https://www.wikidata.org/wiki/Property:P137

And then use it to fetch potentially some or all of the operator stuff if blank.

For example this one: https://www.wikidata.org/wiki/Q271195

bhousel commented 3 years ago

I was suggesting that you could also query Wikidata to see if this is set on the network: https://www.wikidata.org/wiki/Property:P137

And then use it to fetch potentially some or all of the operator stuff if blank.

Ok, that makes sense, thanks! A thing I'd be worried about is whether the Wikidata P137 operator is always used in the same way as the OpenStreetMap operator tag.

I think I might start out by running some queries to see how closely these concepts match up. I agree that it would be great to set OpenStreetMap operator in cases where it is missing.

peternewman commented 3 years ago

A thing I'd be worried about is whether the Wikidata P137 operator is always used in the same wasy as the OpenStreetMap operator tag.

I think I might start out by running some queries to see how closely these concepts match up. I agree that it would be great to set OpenStreetMap operator in cases where it is missing.

Or perhaps just do it as part of the validation then. It could list ones where it's present but not in NSI, or different.