osmlab / name-suggestion-index

Canonical common brand names, operators, transit and flags for OpenStreetMap.
https://nsi.guide
BSD 3-Clause "New" or "Revised" License
706 stars 853 forks source link

Add various UK and crown dependency police forces #4798

Open davidpnewton opened 3 years ago

davidpnewton commented 3 years ago

Entries for various UK police forces not already in the NSI can be added as follows:

{ "displayName": "Civil Nuclear Constabulary", "id": "", "locationSet": {"include": ["gb"]}, "tags": { "amenity": "police", "operator": "Civil Nuclear Constabulary", "operator:wikidata": "Q1094480", "operator:wikipedia": "en:Civil Nuclear Constabulary" }

{ "displayName": "Isle of Man Constabulary", "id": "", "locationSet": {"include": ["im"]}, "tags": { "amenity": "police", "operator": "Isle of Man Constabulary", "operator:wikidata": "Q12262934", "operator:wikipedia": "en:Isle of Man Constabulary" }

{ "displayName": "Ministry of Defence Police", "id": "", "locationSet": {"include": ["gb"]}, "tags": { "amenity": "police", "operator": "Ministry of Defence Police", "operator:wikidata": "Q1937192", "operator:wikipedia": "en:Ministry of Defence Police" }

{ "displayName": "States of Guernsey Police Service", "id": "", "locationSet": {"include": ["gg"]}, "tags": { "amenity": "police", "operator": "States of Guernsey Police Service", "operator:wikidata": "Q7604038", "operator:wikipedia": "en:States of Guernsey Police Service" }

{ "displayName": "States of Jersey Police", "id": "", "locationSet": {"include": ["je"]}, "tags": { "amenity": "police", "operator": "States of Jersey Police", "operator:wikidata": "Q12069992", "operator:wikipedia": "en:States of Jersey Police" }

UKChris-osm commented 3 years ago

Thanks for the data @davidpnewton

When adding UK police stations, I left out the ones listed about because they only had a couple of police stations, so I wasn't sure if they were suitable for the index, but others may disagree.

With the Ministry and Nuclear entries, I left those out because I didn't think they had conventional "public accessible" police stations, but maybe I was incorrect?

bhousel commented 3 years ago

I think it's fine to add anything, as long as it's a thing that occurs frequently and should be tagged consistently.

UKChris-osm commented 3 years ago

I think "Jersey" and "Guernsey" have two stations each, and the "Isle of Man" four stations, would these be worth adding @bhousel?

bhousel commented 3 years ago

I think "Jersey" and "Guernsey" have two stations each, and the "Isle of Man" four stations, would these be worth adding @bhousel?

I wouldn't - those are really low numbers.. We've been using 50 as the threshold for brands, and 10 as the threshold for networks/operators.

UKChris-osm commented 3 years ago

Looking into "Ministry of Defence Police" (37 locations) and "Civil Nuclear Constabulary" (10 locations, all at Nuclear sites I believe), which don't seem to have conventional police stations, I think police=offices might be better for these entries?

davidpnewton commented 3 years ago

Seems a reasonable way of dealing with those two agencies.

I understand about the crown dependency forces being too small to add. Naturally that would equally apply to other smaller agencies as well such as the Royal Gibraltar Police or the Sovereign Base Areas Police. Outside of the UK and UK-controlled areas that would also rule out things like municipal police forces in many US areas as well.

UKChris-osm commented 3 years ago

If using police=offices, would this replace amenity=police and require "/operators/police/offices.json" to be created:

{
  "displayName": "Civil Nuclear Constabulary",
  "locationSet": {"include": ["gb"]},
  "tags": {
    "operator": "Civil Nuclear Constabulary",
    "operator:wikidata": "Q1094480",
    "operator:wikipedia": "en:Civil Nuclear Constabulary"
    "police": "offices"
},
{
  "displayName": "Ministry of Defence Police",
  "locationSet": {"include": ["gb"]},
  "tags": {
    "operator": "Ministry of Defence Police",
    "operator:wikidata": "Q1937192",
    "operator:wikipedia": "en:Ministry of Defence Police",
    "police": "offices"
  }
}

... or is police=offices used as an additional tag along with amenity=police?

bhousel commented 3 years ago

I think we should avoid adding police=offices since that tag doesn't have a lot of use and the documentation of it isn't clear.

A more normal tagging scheme would be to nest the new tag under an established toplevel tag like office=*. For example:

bhousel commented 3 years ago

Just checking in - has there been any movement on this since December?

I'm still ok with adding anything to NSI that is "a thing that occurs frequently and should be tagged consistently." (as long as OSM can agree on what the tags are).