osmlab / name-suggestion-index

Canonical common brand names, operators, transit and flags for OpenStreetMap.
https://nsi.guide
BSD 3-Clause "New" or "Revised" License
709 stars 858 forks source link

Revert e75e60a and only change the name to Aldi instead of ALDI as reported in #9388 / German shop name spelling #9596

Closed fabi003 closed 3 months ago

fabi003 commented 4 months ago

The commit https://github.com/osmlab/name-suggestion-index/commit/e75e60a90b381ed7858ac608ba98360bfec27d05 leads to Bildschirmfoto_20240602_223311 and should be reverted as it made the whole situation worse.

The brand of the shop in the picture is "ALDI Nord" (as you can see from the right brand of "ALDI Nord") and now should be changed to "Aldi". The shop name is "Aldi", but the brand is "ALDI Nord". To understand the background read #8406.

Before this commit everything was right, at least for Germany, but not the shop name, so I reported issue #9388 to only change the shop name from "ALDI" to "Aldi". But instead the right brands (which are different from the shop name, which is right) were also changed, besides of some bad "simplifications".

fabi003 commented 4 months ago

Additional general information for German shop names and brand writing, which should be apply to the most cases:

TL;DR: If the German shop name on the logo/sign is spelled with only capital letters, then name= is written with only the first letter capitalized, but the brand= is always written as on the shop logo/sign. All other spelled German shop names (name=*) are written as on the shop logo.

When the "name on shop (logo)" (=brand=*) of the shop is written only in capital letters, as for "NORMA" , then the German shop name is in most cases written with only the first letter capitalized, so name= of the shop is "Norma", but the brand= should be written as on the shop sign or logo, brand=NORMA in this example. This is why it was reported in #6662.

This also applies to "Penny" (reported for the name in #9337) and "Rossmann" (Background information for Rossmann).

In the above cases the brand should be changed.

The background is, that over long time the shop name is used as a normal German word, even when it is an longer abbreviation as "EDEKA" (was "E. d. K." (spoken "ED"-"DE"-"KA" in German in the past, such as the newer shop name (name=* should also be changed from name=EDEKA to name=Edeka (taginfo: 1488x name=EDEKA, 1274x name=Edeka)))) or "ALDI" (is/was "Albrecht Diskont"). And is the name is a normal German name, then only the first letter is capitalized. There are only a few exceptions of very short abbreviations such as "NP", which can't be spoken (it should contain "A", "E", "I", "O" or "U" for this).

The brand style writing (spelling of the brand should be uniform, so the brand is easy recognized again by customers) is valid only, if the brand is written in publications or on the shop sign, but not as a normal German name, which name= should be. So the brand= should be written as on the shop (logo), website or other publications.

If the shop name is written only in lower lower case letters as "dm" or "tegut" then the shop name and brand is only written in lower case, as this spelling is allowed in German. So name=dm and brand=dm is right for example.

Also no action is required, if the name is already spelled right in German, with first letter capitalized, such as "Müller". Here name=Müller and brand=Müller is right.

I hope this helps you for the future with the spelling of German shop names.

bhousel commented 3 months ago

done in #9630 - we can check it after the next release and see if it needs further adjustment 👍