osmlab / osm-planning

General OSM tools planning and wishlist
Other
18 stars 1 forks source link

Improved activity/history tab #15

Open bhousel opened 6 years ago

bhousel commented 6 years ago

from https://wiki.openstreetmap.org/wiki/Top_Ten_Tasks#Improved_activity.2Fhistory_tab

Improved activity/history tab

The history tab on the front page shows recent changesets in the area displayed. However, due to worldwide changes (often automated edits or bots) it is a well-known problem that many of these changes are uninteresting and merely have bounding boxes which overlap the field of view, no actual changes inside it.

In the end of December 2012 OWL reached beta status and solved for some this problem by integrating with the main website to create a more interactive History tab (see beta). As of 2015, the OWL website was unusably slow, and as of 2018, it is no longer online. Currently, there is no good way for listing changesets actually affecting a given area.

To solve this, you have to mind not only the database size, which will be measured in terabytes, but also speed and user experience. It should render the last 10-20 changesets for any given filtering options in a second for thousands of simultaneous users, and the resulting map should not be too messy.


_This issue comes from the OSM Top Ten Tasks page_

bhousel commented 6 years ago

See also OSMCha: https://osmcha.mapbox.com/ which might cover everything described in this issue.

https://github.com/mapbox/osmcha-frontend/labels/good%20first%20issue

ppawel commented 6 years ago

I looked at OSMCha but it seems like a changeset browser, meaning it does not address the fundamental problem of the current History tab approach and also the problem with all the tools I have seen that are "history viewers": you can't see a feed of your local changes because most of these tools are using changeset bounding box to apply the filter which means you will get worldwide bot edits as part of your local feed.

For example, see this URL where I applied filter to include changesets from Munich, Germany:

https://osmcha.mapbox.com/changesets/59359559?filters=%7B%22geometry%22%3A%5B%7B%22label%22%3A%7B%22type%22%3A%22MultiPolygon%22%2C%22coordinates%22%3A%5B%5B%5B%5B11.360777%2C48.1580704%5D%2C%5B11.7090286%2C48.1023941%5D%2C%5B11.5663438%2C48.2273043%5D%2C%5B11.360777%2C48.1580704%5D%5D%5D%2C%5B%5B%5B11.4902263%2C48.073821%5D%2C%5B11.4909805%2C48.0741023%5D%2C%5B11.490724%2C48.0742575%5D%2C%5B11.4902263%2C48.073821%5D%5D%5D%2C%5B%5B%5B11.5560672%2C48.0799449%5D%2C%5B11.5577562%2C48.0795803%5D%2C%5B11.5563954%2C48.0804318%5D%2C%5B11.5560672%2C48.0799449%5D%5D%5D%5D%7D%2C%22value%22%3A%7B%22type%22%3A%22MultiPolygon%22%2C%22coordinates%22%3A%5B%5B%5B%5B11.360777%2C48.1580704%5D%2C%5B11.7090286%2C48.1023941%5D%2C%5B11.5663438%2C48.2273043%5D%2C%5B11.360777%2C48.1580704%5D%5D%5D%2C%5B%5B%5B11.4902263%2C48.073821%5D%2C%5B11.4909805%2C48.0741023%5D%2C%5B11.490724%2C48.0742575%5D%2C%5B11.4902263%2C48.073821%5D%5D%5D%2C%5B%5B%5B11.5560672%2C48.0799449%5D%2C%5B11.5577562%2C48.0795803%5D%2C%5B11.5563954%2C48.0804318%5D%2C%5B11.5560672%2C48.0799449%5D%5D%5D%5D%7D%7D%5D%7D

It is full of worldwide stuff like wheelmap imports, large-scale reverts etc.

With OWL we solved that and also more problems (you could see full geometry of changesets etc.) but it never got to production as it was too much effort to maintain and operate the system. By now I see there is 10x more changesets in OSM than when I was working on this problem back in 2012/2013 so the solution would need to scale even better.

bhousel commented 6 years ago

I looked at OSMCha but it seems like a changeset browser, meaning it does not address the fundamental problem of the current History tab approach and also the problem with all the tools I have seen that are "history viewers": you can't see a feed of your local changes because most of these tools are using changeset bounding box to apply the filter which means you will get worldwide bot edits as part of your local feed.

I think it's possible, but I admit it is tricky to get the filters just right. This is a saved query of only my edits.

https://osmcha.mapbox.com/?filters=%7B%22users%22%3A%5B%7B%22label%22%3A%22bhousel%22%2C%22value%22%3A%22bhousel%22%7D%5D%2C%22order_by%22%3A%5B%7B%22label%22%3A%22Descending%20Date%22%2C%22value%22%3A%22-date%22%7D%5D%2C%22date__gte%22%3A%5B%7B%22label%22%3A%22%22%2C%22value%22%3A%22%22%7D%5D%7D

It does seem to match exactly the output of the history url: https://www.openstreetmap.org/user/bhousel/history#map=3/11.72/-61.86

To your point about the bounding boxes, it sounds like you are saying the issue is that when you define an area of interest (show me changes inside a specific place), a worldwide spanning changeset will be included in this even if it contains edits that aren't actually inside that place. If this is the case, do you think it's something we should open an issue for on OSMCha for discussion? Maybe they can adjust the filters for this?

mmd-osm commented 5 years ago

If this is the case, do you think it's something we should open an issue for on OSMCha for discussion?

Isn't OSMCha's filtering also based on bounding boxes? I just gave it a try, and results for a small bbox include worldwide stuff.

Adjusting filters probably won't be sufficient, if a bounding box is the only meta information OSMCha has about a changeset. If that bbox is very large, those changes might occur just about anywhere, except for your area of interest. Analyzing hundreds or even thousands of changesets on the fly would be prohibitively expensive, i.e. some different approaches to get to the relevant changesets would be required.

By the way, did you take a look at latest-changes by @tyrasd already? https://tyrasd.github.io/latest-changes