search

osmlab / osmlint

An open source suite of js validators for OpenStreetMap data, to identify common geometry and metadata problems at scale.
ISC License
84 stars 10 forks source link

Invalid Turn lanes #244

Closed abhisheksaikia closed 7 years ago

abhisheksaikia commented 7 years ago

slight_left and slight_right are taken as left and right turn lane by OSRM. There are some wrongly mapped slight_left which should actually be merge_to_left and similar for slight_right. Can we modify the invalid turn lanes detector for including these errors?

@Rub21 @samely

cc @maning @jothirnadh @srividyacb

Rub21 commented 7 years ago

@abhisheksaikia Can you give an example or scenarios

abhisheksaikia commented 7 years ago

@Rub21 Ran an overpass query to get all the slight_left which is not in the left lane. The results are very low(only 23) all over the US but it should be included in the validator just so to detect these edge cases and check them if they are correct

Rub21 commented 7 years ago

@abhisheksaikia Looks like the issues are well mapped!! 👇

screen shot 2017-08-07 at 4 06 39 pm screen shot 2017-08-07 at 4 07 18 pm

According the invalid turnlanes validator the rigt position for each turns are: 

'reverse', 'sharp_left', 'left', 'slight_left', 'merge_to_right', 'through', 'merge_to_left', 'slight_right', 'right', 'sharp_right'

https://wiki.openstreetmap.org/wiki/Key:turn#Turning_indications_per_lane

If that ☝️ does not satisfy the validator should detect the error,

I ran the invalid turnalnes validator for USA: most of them are issues where the turns does not match with the lanes, but some of them turns position issues like:

image

https://www.openstreetmap.org/way/499425314/history

turn:lanes:forward=through;left|right This should be 👉 turn:lanes:forward=left;through|right

Rub21 commented 7 years ago

This was fixed here https://github.com/osmlab/osmlint/pull/249, close this ticket