search

osmose-model / osmose-web-api

Web service that generates Osmose configuration files from data sources like Fishbase and SeaLifeBase. Used by https://www.config.osmose-model.org .
MIT License
2 stars 2 forks source link

show error message in UI when osmose_config.zip fails to generate #102

Closed jhpoelen closed 7 years ago

jhpoelen commented 7 years ago

expected: Whenever a call to the configuration api returns an error (non-200 ok), the user should be notified.

observated: when a call to configuration timed-out and created a 503, the user was not notified.

see #66 .

jhpoelen commented 7 years ago

@FIN-casey @FIN-JBarile this is a UI issue - which label do we use for that?

FIN-casey commented 7 years ago

@jhpoelen @agruss2 , I implemented the display of error message when the osmose config fails to generate. The displayed message is "Generating configuration is not successful." in red font.

Please check so we can close this issue.

agruss2 commented 7 years ago

@jhpoelen I have made several tests with the UI, which have all succeeded; therefore, I am not able to check what Casey recently implemented. Please check, and close this issue if this is relevant.

jhpoelen commented 7 years ago

Here's what I did to confirm the behavior:

  1. select "gulf of mexico"
  2. proceed to submit page
  3. turn off network on my machine
  4. click "submit"

Expected json configuration is now available for download.

I am sure there's many ways to make the UI a little more intuitive, and we'll probably come up with some ways as we expand the user audience.