search

osmose-model / osmose-web-api

Web service that generates Osmose configuration files from data sources like Fishbase and SeaLifeBase. Used by https://www.config.osmose-model.org .
MIT License
2 stars 2 forks source link

UI Step 2 - Issue no. 13 #110

Closed agruss2 closed 7 years ago

agruss2 commented 7 years ago

I just ran a test with the UI, where I requested parameters for an OSMOSE model for the Iceland/Shelf Sea ecosystem. In the table provided in Step 2, I noticed that some of the functional groups defined by the UI include both fish species and invertebrate species. For example, the "pelagicsm" functional group includes: (1) three fish species: Mallotus villosus, Benthosema glaciale, and Notoscopelus kroyeri (Actinopterygii); and (2) one invertebrate species: Calanus finmarchicus (Maxillopoda). Instead of one single "pelagicsm" functional group, the UI should define two functional groups: (1) "fishpelagicsm", including the three fish species; and (2) "invertpelagicsm" including the invertebrate species.

-----> All the functional groups defined by the UI should include: (1) only fish species; or (2) only invertebrate species.

Could you please correct for this? Many thanks.

FIN-casey commented 7 years ago

@agruss2 The functional groups of fish species and invertebrate species are now separated. The functional group names are also modified to include fish and invert term. Please verify. Thanks

agruss2 commented 7 years ago

@FIN-casey Thanks a lot for having implemented this; I can now close the present issue.