osmose-model / osmose-web-api

Web service that generates Osmose configuration files from data sources like Fishbase and SeaLifeBase. Used by https://www.config.osmose-model.org .
MIT License
2 stars 2 forks source link

The trophic level of a biotic resource cannot be lower than 2 #179

Closed agruss2 closed 5 years ago

agruss2 commented 5 years ago

@jhpoelen To test whether #175 was fulled solved, I ran a test today, where I queried parameter estimates for the Gulf of Mexico for the OSMOSE model of the West Florida Shelf (“OSMOSE-WFS”). The majority of the issues we were previously facing were solved, which is really great. However, there are a few issues that remain to be solved, which is why I opened the present GitHub issue. We have an issue with the trophic level of one biotic resource, which the API set to 0.0, while the trophic level of biotic resources cannot be set to a value below 2, because this is not realistic from an ecological point of view since the trophic levels of primary consumers cannot be lower than 2; please see: osmose_config.zip What this means here is that the API found a value for one of the species represented in the echinoderms and gastropods’ group in the “Troph” column of the SeaLifeBase’s table “estimate”. However, either (ii) this value that the API found was above 2, in which case the API wrongly set the trophic level of the echinoderms and gastropods’ group to 0.0; or (ii) the value entered in the “Troph” column of the SeaLifeBase’s table “estimate” was 0.0, in which case we need to put constraints on the API so that it sets the value of trophic level to 2 when a value below 2 is given in the “Troph” column of the FishBase/SeaLifeBase’s table “estimate”. Could you please fix this issue and then let me know so that I can run a new test with the web application? Many thanks!

agruss2 commented 5 years ago

@jhpoelen
I have some great news. I just ran a test where I queried parameter estimates for the Gulf of Mexico for the OSMOSE-WFS model, and I can confirm that the present issue has been solved. Thanks a lot! Closing this issue now.